Commit c80dd3fc authored by Filipe Xavier's avatar Filipe Xavier Committed by Miguel Ojeda
Browse files

rust: uaccess: generalize userSliceReader to support any Vec 

The UserSliceReader::read_all function is currently restricted to use
only Vec with the kmalloc allocator. However, there is no reason for
this limitation.

This patch generalizes the function to accept any Vec regardless of the
allocator used.

There's a use-case for a KVVec in Binder to avoid maximum sizes for a
certain array.

Link: https://github.com/Rust-for-Linux/linux/issues/1136


Signed-off-by: default avatarFilipe Xavier <felipeaggger@gmail.com>
Reviewed-by: default avatarAlice Ryhl <aliceryhl@google.com>
Reviewed-by: default avatarBoqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20250107-gen-userslice-readall-alloc-v2-1-d7fe4d19241a@gmail.com


[ Reflowed and slightly reworded title. - Miguel ]
Signed-off-by: default avatarMiguel Ojeda <ojeda@kernel.org>
parent c27e705c

rust/kernel/uaccess.rs

+3 −3
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
//! C header: [`include/linux/uaccess.h`](srctree/include/linux/uaccess.h)



use crate::{

    alloc::Flags,

    alloc::{Allocator, Flags},

    bindings,

    error::Result,

    ffi::c_void,
@@ -127,7 +127,7 @@ pub fn new(ptr: UserPtr, length: usize) -> Self { 
    /// Reads the entirety of the user slice, appending it to the end of the provided buffer.

    ///

    /// Fails with [`EFAULT`] if the read happens on a bad address.

    pub fn read_all(self, buf: &mut KVec<u8>, flags: Flags) -> Result {

    pub fn read_all<A: Allocator>(self, buf: &mut Vec<u8, A>, flags: Flags) -> Result {

        self.reader().read_all(buf, flags)

    }
@@ -281,7 +281,7 @@ pub fn read<T: FromBytes>(&mut self) -> Result<T> { 
    /// Reads the entirety of the user slice, appending it to the end of the provided buffer.

    ///

    /// Fails with [`EFAULT`] if the read happens on a bad address.

    pub fn read_all(mut self, buf: &mut KVec<u8>, flags: Flags) -> Result {

    pub fn read_all<A: Allocator>(mut self, buf: &mut Vec<u8, A>, flags: Flags) -> Result {

        let len = self.length;

        buf.reserve(len, flags)?;