Commit c81d9fcd authored by Michal Pecio's avatar Michal Pecio Committed by Greg Kroah-Hartman
Browse files

usb: xhci: Restore xhci_pci support for Renesas HCs 

Some Renesas HCs require firmware upload to work, this is handled by the
xhci_pci_renesas driver. Other variants of those chips load firmware from
a SPI flash and are ready to work with xhci_pci alone.

A refactor merged in v6.12 broke the latter configuration so that users
are finding their hardware ignored by the normal driver and are forced to
enable the firmware loader which isn't really necessary on their systems.

Let xhci_pci work with those chips as before when the firmware loader is
disabled by kernel configuration.

Fixes: 25f51b76 ("xhci-pci: Make xhci-pci-renesas a proper modular driver")
Cc: stable <stable@kernel.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219616
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219726


Signed-off-by: default avatarMichal Pecio <michal.pecio@gmail.com>
Tested-by: default avatarNicolai Buchwitz <nb@tipi-net.de>
Link: https://lore.kernel.org/r/20250128104529.58a79bfc@foxbook


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e71f7f42

drivers/usb/host/xhci-pci.c

+4 −3
Original line number Diff line number Diff line
@@ -653,8 +653,8 @@ int xhci_pci_common_probe(struct pci_dev *dev, const struct pci_device_id *id) 
}

EXPORT_SYMBOL_NS_GPL(xhci_pci_common_probe, "xhci");



static const struct pci_device_id pci_ids_reject[] = {

	/* handled by xhci-pci-renesas */

/* handled by xhci-pci-renesas if enabled */

static const struct pci_device_id pci_ids_renesas[] = {

	{ PCI_DEVICE(PCI_VENDOR_ID_RENESAS, 0x0014) },

	{ PCI_DEVICE(PCI_VENDOR_ID_RENESAS, 0x0015) },

	{ /* end: all zeroes */ }
@@ -662,7 +662,8 @@ static const struct pci_device_id pci_ids_reject[] = { 


static int xhci_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)

{

	if (pci_match_id(pci_ids_reject, dev))

	if (IS_ENABLED(CONFIG_USB_XHCI_PCI_RENESAS) &&

			pci_match_id(pci_ids_renesas, dev))

		return -ENODEV;



	return xhci_pci_common_probe(dev, id);