Commit c82c5071 authored by Vasily Khoruzhick's avatar Vasily Khoruzhick Committed by Rafael J. Wysocki
Browse files

ACPICA: executer/exsystem: Don't nag user about every Stall() violating the spec 

ACPICA commit 129b75516fc49fe1fd6b8c5798f86c13854630b3

Stop nagging user about every Stall() that violates the spec

On my Dell XPS 15 7590 I get hundreds of these warnings after few hours of
uptime:

$ dmesg | grep "fix the firmware" | wc -l
261

I cannot fix the firmware and I doubt that Dell cares about 4 year old
laptop either

Fixes: ace8f1c5 ("ACPICA: executer/exsystem: Inform users about ACPI spec violation")
Link: https://github.com/acpica/acpica/commit/129b7551


Signed-off-by: default avatarVasily Khoruzhick <anarsoul@gmail.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 632b746b

drivers/acpi/acpica/exsystem.c

+6 −5
Original line number Diff line number Diff line
@@ -133,12 +133,13 @@ acpi_status acpi_ex_system_do_stall(u32 how_long_us) 
		 * (ACPI specifies 100 usec as max, but this gives some slack in

		 * order to support existing BIOSs)

		 */

		ACPI_ERROR((AE_INFO,

			    "Time parameter is too large (%u)", how_long_us));

		ACPI_ERROR_ONCE((AE_INFO,

				 "Time parameter is too large (%u)",

				 how_long_us));

		status = AE_AML_OPERAND_VALUE;

	} else {

		if (how_long_us > 100) {

			ACPI_WARNING((AE_INFO,

			ACPI_WARNING_ONCE((AE_INFO,

					   "Time parameter %u us > 100 us violating ACPI spec, please fix the firmware.",

					   how_long_us));

		}