Commit c836e5a7 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/chip: Rework irq_set_msi_desc_off() 



Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

Fixup the kernel doc comment while at it.

No functional change.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065421.473563978@linutronix.de
parent 321a0fdf

kernel/irq/chip.c

+17 −21
Original line number Diff line number Diff line
@@ -91,20 +91,16 @@ EXPORT_SYMBOL(irq_set_handler_data); 
 *

 * Set the MSI descriptor entry for an irq at offset

 */

int irq_set_msi_desc_off(unsigned int irq_base, unsigned int irq_offset,

			 struct msi_desc *entry)

int irq_set_msi_desc_off(unsigned int irq_base, unsigned int irq_offset, struct msi_desc *entry)

{

	unsigned long flags;

	struct irq_desc *desc = irq_get_desc_lock(irq_base + irq_offset, &flags, IRQ_GET_DESC_CHECK_GLOBAL);



	if (!desc)

		return -EINVAL;

	desc->irq_common_data.msi_desc = entry;

	scoped_irqdesc_get_and_lock(irq_base + irq_offset, IRQ_GET_DESC_CHECK_GLOBAL) {

		scoped_irqdesc->irq_common_data.msi_desc = entry;

		if (entry && !irq_offset)

			entry->irq = irq_base;

	irq_put_desc_unlock(desc, flags);

		return 0;

	}

	return -EINVAL;

}



/**

 * irq_set_msi_desc - set MSI descriptor data for an irq