Unverified Commit c849ecb2 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Xu Yilun
Browse files

fpga: zynq-fpga: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: default avatarXu Yilun <yilun.xu@intel.com>
Link: https://lore.kernel.org/r/e63d4155f96f3504f7e3d6a4775c3807c90dd6ce.1703006638.git.u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarXu Yilun <yilun.xu@linux.intel.com>
parent a584df30

drivers/fpga/zynq-fpga.c

+2 −4
Original line number Diff line number Diff line
@@ -618,7 +618,7 @@ static int zynq_fpga_probe(struct platform_device *pdev) 
	return 0;

}



static int zynq_fpga_remove(struct platform_device *pdev)

static void zynq_fpga_remove(struct platform_device *pdev)

{

	struct zynq_fpga_priv *priv;

	struct fpga_manager *mgr;
@@ -629,8 +629,6 @@ static int zynq_fpga_remove(struct platform_device *pdev) 
	fpga_mgr_unregister(mgr);



	clk_unprepare(priv->clk);



	return 0;

}



#ifdef CONFIG_OF
@@ -644,7 +642,7 @@ MODULE_DEVICE_TABLE(of, zynq_fpga_of_match); 


static struct platform_driver zynq_fpga_driver = {

	.probe = zynq_fpga_probe,

	.remove = zynq_fpga_remove,

	.remove_new = zynq_fpga_remove,

	.driver = {

		.name = "zynq_fpga_manager",

		.of_match_table = of_match_ptr(zynq_fpga_of_match),