Unverified Commit c8682a33 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Krzysztof Wilczyński
Browse files

PCI: dwc: ep: Rename dw_pcie_ep_exit() to dw_pcie_ep_deinit() 

dw_pcie_ep_exit() API is undoing what the dw_pcie_ep_init() API has done
already (at least partly). But the API name dw_pcie_ep_exit() is not quite
reflecting that. So let's rename it to dw_pcie_ep_deinit() to make the
purpose of this API clear. This also aligns with the DWC host driver.

Link: https://patchwork.kernel.org/project/linux-pci/patch/20240327-pci-dbi-rework-v12-4-082625472414@linaro.org


Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
Reviewed-by: default avatarYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
parent b7dec6b8

drivers/pci/controller/dwc/pcie-designware-ep.c

+3 −3
Original line number Diff line number Diff line
@@ -620,13 +620,13 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, 
}



/**

 * dw_pcie_ep_exit - Deinitialize the endpoint device

 * dw_pcie_ep_deinit - Deinitialize the endpoint device

 * @ep: DWC EP device

 *

 * Deinitialize the endpoint device. EPC device is not destroyed since that will

 * be taken care by Devres.

 */

void dw_pcie_ep_exit(struct dw_pcie_ep *ep)

void dw_pcie_ep_deinit(struct dw_pcie_ep *ep)

{

	struct dw_pcie *pci = to_dw_pcie_from_ep(ep);

	struct pci_epc *epc = ep->epc;
@@ -638,7 +638,7 @@ void dw_pcie_ep_exit(struct dw_pcie_ep *ep) 


	pci_epc_mem_exit(epc);

}

EXPORT_SYMBOL_GPL(dw_pcie_ep_exit);

EXPORT_SYMBOL_GPL(dw_pcie_ep_deinit);



static unsigned int dw_pcie_ep_find_ext_capability(struct dw_pcie *pci, int cap)

{

drivers/pci/controller/dwc/pcie-designware.h

+2 −2
Original line number Diff line number Diff line
@@ -671,7 +671,7 @@ void dw_pcie_ep_linkup(struct dw_pcie_ep *ep); 
int dw_pcie_ep_init(struct dw_pcie_ep *ep);

int dw_pcie_ep_init_complete(struct dw_pcie_ep *ep);

void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep);

void dw_pcie_ep_exit(struct dw_pcie_ep *ep);

void dw_pcie_ep_deinit(struct dw_pcie_ep *ep);

int dw_pcie_ep_raise_intx_irq(struct dw_pcie_ep *ep, u8 func_no);

int dw_pcie_ep_raise_msi_irq(struct dw_pcie_ep *ep, u8 func_no,

			     u8 interrupt_num);
@@ -701,7 +701,7 @@ static inline void dw_pcie_ep_init_notify(struct dw_pcie_ep *ep) 
{

}



static inline void dw_pcie_ep_exit(struct dw_pcie_ep *ep)

static inline void dw_pcie_ep_deinit(struct dw_pcie_ep *ep)

{

}

drivers/pci/controller/dwc/pcie-rcar-gen4.c

+1 −1
Original line number Diff line number Diff line
@@ -432,7 +432,7 @@ static int rcar_gen4_add_dw_pcie_ep(struct rcar_gen4_pcie *rcar) 


static void rcar_gen4_remove_dw_pcie_ep(struct rcar_gen4_pcie *rcar)

{

	dw_pcie_ep_exit(&rcar->dw.ep);

	dw_pcie_ep_deinit(&rcar->dw.ep);

	rcar_gen4_pcie_ep_deinit(rcar);

}