Commit c8a9c285 authored by Rasmus Villemoes's avatar Rasmus Villemoes Committed by Greg Kroah-Hartman
Browse files

debugfs: drop pointless nul-termination in debugfs_read_file_bool() 



simple_read_from_buffer() doesn't care about any bytes in the buffer
beyond "available". Making the buffer nul-terminated is therefore
completely pointless.

Signed-off-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Link: https://lore.kernel.org/r/20210326151411.732220-1-linux@rasmusvillemoes.dk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 72a91f19

fs/debugfs/file.c

+1 −2
Original line number Diff line number Diff line
@@ -773,7 +773,7 @@ EXPORT_SYMBOL_GPL(debugfs_create_atomic_t); 
ssize_t debugfs_read_file_bool(struct file *file, char __user *user_buf,

			       size_t count, loff_t *ppos)

{

	char buf[3];

	char buf[2];

	bool val;

	int r;

	struct dentry *dentry = F_DENTRY(file);
@@ -789,7 +789,6 @@ ssize_t debugfs_read_file_bool(struct file *file, char __user *user_buf, 
	else

		buf[0] = 'N';

	buf[1] = '\n';

	buf[2] = 0x00;

	return simple_read_from_buffer(user_buf, count, ppos, buf, 2);

}

EXPORT_SYMBOL_GPL(debugfs_read_file_bool);