Unverified Commit c8b2e5c1 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: rt712-sdca-sdw: fix locking sequence 



The disable_irq_lock protects the 'disable_irq' value, we need to lock
before testing it.

Fixes: 7a8735c1 ("ASoC: rt712-sdca: fix for JD event handling in ClockStop Mode0")
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarChao Song <chao.song@linux.intel.com>
Link: https://msgid.link/r/20240325221817.206465-5-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent aae86cfd

sound/soc/codecs/rt712-sdca-sdw.c

+3 −2
Original line number Diff line number Diff line
@@ -438,13 +438,14 @@ static int __maybe_unused rt712_sdca_dev_resume(struct device *dev) 
		return 0;



	if (!slave->unattach_request) {

		if (rt712->disable_irq == true) {

		mutex_lock(&rt712->disable_irq_lock);

		if (rt712->disable_irq == true) {



			sdw_write_no_pm(slave, SDW_SCP_SDCA_INTMASK1, SDW_SCP_SDCA_INTMASK_SDCA_0);

			sdw_write_no_pm(slave, SDW_SCP_SDCA_INTMASK2, SDW_SCP_SDCA_INTMASK_SDCA_8);

			rt712->disable_irq = false;

			mutex_unlock(&rt712->disable_irq_lock);

		}

		mutex_unlock(&rt712->disable_irq_lock);

		goto regmap_sync;

	}