Commit c8bf0b96 authored by Rusydi H. Makarim's avatar Rusydi H. Makarim Committed by Eric Biggers
Browse files

lib/crypto: md5: Use rol32() instead of open-coding it 



For the bitwise left rotation in MD5STEP, use rol32() from
<linux/bitops.h> instead of open-coding it.

Signed-off-by: default avatarRusydi H. Makarim <rusydi.makarim@kriptograf.id>
Link: https://lore.kernel.org/r/20251214-rol32_in_md5-v1-1-20f5f11a92b2@kriptograf.id


Signed-off-by: default avatarEric Biggers <ebiggers@kernel.org>
parent 0d8e6c0a

lib/crypto/md5.c

+1 −1
Original line number Diff line number Diff line
@@ -29,7 +29,7 @@ static const struct md5_block_state md5_iv = { 
#define F4(x, y, z) (y ^ (x | ~z))



#define MD5STEP(f, w, x, y, z, in, s) \

	(w += f(x, y, z) + in, w = (w << s | w >> (32 - s)) + x)

	(w += f(x, y, z) + in, w = rol32(w, s) + x)



static void md5_block_generic(struct md5_block_state *state,

			      const u8 data[MD5_BLOCK_SIZE])