Commit c8d0a7d6 authored by Ido Schimmel's avatar Ido Schimmel Committed by David S. Miller
Browse files

devlink: Enable the use of private flags in post_doit operations 



Currently, private flags (e.g., 'DEVLINK_NL_FLAG_NEED_PORT') are only
used in pre_doit operations, but a subsequent patch will need to
conditionally lock and unlock the device lock in pre and post doit
operations, respectively.

As a preparation, enable the use of private flags in post_doit
operations in a similar fashion to how it is done for pre_doit
operations.

No functional changes intended.

Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e21c52d7

net/devlink/netlink.c

+8 −2
Original line number Diff line number Diff line
@@ -141,8 +141,8 @@ int devlink_nl_pre_doit_port_optional(const struct genl_split_ops *ops, 
	return __devlink_nl_pre_doit(skb, info, DEVLINK_NL_FLAG_NEED_DEVLINK_OR_PORT);

}



void devlink_nl_post_doit(const struct genl_split_ops *ops,

			  struct sk_buff *skb, struct genl_info *info)

static void __devlink_nl_post_doit(struct sk_buff *skb, struct genl_info *info,

				   u8 flags)

{

	struct devlink *devlink;
@@ -151,6 +151,12 @@ void devlink_nl_post_doit(const struct genl_split_ops *ops, 
	devlink_put(devlink);

}



void devlink_nl_post_doit(const struct genl_split_ops *ops,

			  struct sk_buff *skb, struct genl_info *info)

{

	__devlink_nl_post_doit(skb, info, 0);

}



static int devlink_nl_inst_single_dumpit(struct sk_buff *msg,

					 struct netlink_callback *cb, int flags,

					 devlink_nl_dump_one_func_t *dump_one,