Commit c8ebd3a3 authored by Adrian Bunk's avatar Adrian Bunk Committed by John W. Linville
Browse files

[PATCH] drivers/net/sk98lin/skge.c: make SkPciWriteCfgDWord() a static inline 



No external user and that small - such a function should be static
inline and not a global function.

Signed-off-by: default avatarAdrian Bunk <bunk@stusta.de>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent cd52d1ee

drivers/net/sk98lin/h/skvpd.h

+0 −8
Original line number Diff line number Diff line
@@ -130,14 +130,12 @@ typedef struct s_vpd_key { 
#ifndef VPD_DO_IO

#define VPD_OUT8(pAC,IoC,Addr,Val)	(void)SkPciWriteCfgByte(pAC,Addr,Val)

#define VPD_OUT16(pAC,IoC,Addr,Val)	(void)SkPciWriteCfgWord(pAC,Addr,Val)

#define VPD_OUT32(pAC,IoC,Addr,Val)	(void)SkPciWriteCfgDWord(pAC,Addr,Val)

#define VPD_IN8(pAC,IoC,Addr,pVal)	(void)SkPciReadCfgByte(pAC,Addr,pVal)

#define VPD_IN16(pAC,IoC,Addr,pVal)	(void)SkPciReadCfgWord(pAC,Addr,pVal)

#define VPD_IN32(pAC,IoC,Addr,pVal)	(void)SkPciReadCfgDWord(pAC,Addr,pVal)

#else	/* VPD_DO_IO */

#define VPD_OUT8(pAC,IoC,Addr,Val)	SK_OUT8(IoC,PCI_C(Addr),Val)

#define VPD_OUT16(pAC,IoC,Addr,Val)	SK_OUT16(IoC,PCI_C(Addr),Val)

#define VPD_OUT32(pAC,IoC,Addr,Val)	SK_OUT32(IoC,PCI_C(Addr),Val)

#define VPD_IN8(pAC,IoC,Addr,pVal)	SK_IN8(IoC,PCI_C(Addr),pVal)

#define VPD_IN16(pAC,IoC,Addr,pVal)	SK_IN16(IoC,PCI_C(Addr),pVal)

#define VPD_IN32(pAC,IoC,Addr,pVal)	SK_IN32(IoC,PCI_C(Addr),pVal)
@@ -155,12 +153,6 @@ typedef struct s_vpd_key { 
		else						\

			SK_OUT16(pAC,PCI_C(Addr),Val);		\

		}

#define VPD_OUT32(pAC,Ioc,Addr,Val) {			\

		if ((pAC)->DgT.DgUseCfgCycle)			\

			SkPciWriteCfgDWord(pAC,Addr,Val);	\

		else						\

			SK_OUT32(pAC,PCI_C(Addr),Val); 		\

		}

#define VPD_IN8(pAC,Ioc,Addr,pVal) {			\

		if ((pAC)->DgT.DgUseCfgCycle) 			\

			SkPciReadCfgByte(pAC,Addr,pVal);	\

drivers/net/sk98lin/skge.c

+21 −22
Original line number Diff line number Diff line
@@ -277,6 +277,27 @@ extern struct ethtool_ops SkGeEthtoolOps; 
static uintptr_t TxQueueAddr[SK_MAX_MACS][2] = {{0x680, 0x600},{0x780, 0x700}};

static uintptr_t RxQueueAddr[SK_MAX_MACS] = {0x400, 0x480};



/*****************************************************************************

 *

 *	SkPciWriteCfgDWord - write a 32 bit value to pci config space

 *

 * Description:

 *	This routine writes a 32 bit value to the pci configuration

 *	space.

 *

 * Returns:

 *	0 - indicate everything worked ok.

 *	!= 0 - error indication

 */

static inline int SkPciWriteCfgDWord(

SK_AC *pAC,	/* Adapter Control structure pointer */

int PciAddr,		/* PCI register address */

SK_U32 Val)		/* pointer to store the read value */

{

	pci_write_config_dword(pAC->PciDev, PciAddr, Val);

	return(0);

} /* SkPciWriteCfgDWord */



/*****************************************************************************

 *

 * 	SkGeInitPCI - Init the PCI resources
@@ -4083,28 +4104,6 @@ SK_U8 *pVal) /* pointer to store the read value */ 
} /* SkPciReadCfgByte */





/*****************************************************************************

 *

 *	SkPciWriteCfgDWord - write a 32 bit value to pci config space

 *

 * Description:

 *	This routine writes a 32 bit value to the pci configuration

 *	space.

 *

 * Returns:

 *	0 - indicate everything worked ok.

 *	!= 0 - error indication

 */

int SkPciWriteCfgDWord(

SK_AC *pAC,	/* Adapter Control structure pointer */

int PciAddr,		/* PCI register address */

SK_U32 Val)		/* pointer to store the read value */

{

	pci_write_config_dword(pAC->PciDev, PciAddr, Val);

	return(0);

} /* SkPciWriteCfgDWord */





/*****************************************************************************

 *

 *	SkPciWriteCfgWord - write a 16 bit value to pci config space