Commit c8fba5d6 authored by Oliver Hartkopp's avatar Oliver Hartkopp Committed by Marc Kleine-Budde
Browse files

can: raw: fix getsockopt() for new CAN_RAW_XL_VCID_OPTS 



The code for the CAN_RAW_XL_VCID_OPTS getsockopt() was incompletely adopted
from the CAN_RAW_FILTER getsockopt().

Add the missing put_user() and return statements.

Flagged by Smatch.

Fixes: c83c22ec ("can: canxl: add virtual CAN network identifier support")
Reported-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarOliver Hartkopp <socketcan@hartkopp.net>
Link: https://lore.kernel.org/all/20240219200021.12113-1-socketcan@hartkopp.net


Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent a93fca92

net/can/raw.c

+3 −1
Original line number Diff line number Diff line
@@ -835,7 +835,9 @@ static int raw_getsockopt(struct socket *sock, int level, int optname, 
			if (copy_to_user(optval, &ro->raw_vcid_opts, len))

				err = -EFAULT;

		}

		break;

		if (!err)

			err = put_user(len, optlen);

		return err;



	case CAN_RAW_JOIN_FILTERS:

		if (len > sizeof(int))