Commit c9099a28 authored by Darrick J. Wong's avatar Darrick J. Wong
Browse files

xfs: remove xfs_trans_set_rmap_flags 



Remove this single-use helper.

Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
parent fbe8c7e1

fs/xfs/xfs_rmap_item.c

+34 −45
Original line number Diff line number Diff line
@@ -226,49 +226,6 @@ static const struct xfs_item_ops xfs_rud_item_ops = { 
	.iop_intent	= xfs_rud_item_intent,

};



/* Set the map extent flags for this reverse mapping. */

static void

xfs_trans_set_rmap_flags(

	struct xfs_map_extent		*map,

	enum xfs_rmap_intent_type	type,

	int				whichfork,

	xfs_exntst_t			state)

{

	map->me_flags = 0;

	if (state == XFS_EXT_UNWRITTEN)

		map->me_flags |= XFS_RMAP_EXTENT_UNWRITTEN;

	if (whichfork == XFS_ATTR_FORK)

		map->me_flags |= XFS_RMAP_EXTENT_ATTR_FORK;

	switch (type) {

	case XFS_RMAP_MAP:

		map->me_flags |= XFS_RMAP_EXTENT_MAP;

		break;

	case XFS_RMAP_MAP_SHARED:

		map->me_flags |= XFS_RMAP_EXTENT_MAP_SHARED;

		break;

	case XFS_RMAP_UNMAP:

		map->me_flags |= XFS_RMAP_EXTENT_UNMAP;

		break;

	case XFS_RMAP_UNMAP_SHARED:

		map->me_flags |= XFS_RMAP_EXTENT_UNMAP_SHARED;

		break;

	case XFS_RMAP_CONVERT:

		map->me_flags |= XFS_RMAP_EXTENT_CONVERT;

		break;

	case XFS_RMAP_CONVERT_SHARED:

		map->me_flags |= XFS_RMAP_EXTENT_CONVERT_SHARED;

		break;

	case XFS_RMAP_ALLOC:

		map->me_flags |= XFS_RMAP_EXTENT_ALLOC;

		break;

	case XFS_RMAP_FREE:

		map->me_flags |= XFS_RMAP_EXTENT_FREE;

		break;

	default:

		ASSERT(0);

	}

}



/* Sort rmap intents by AG. */

static int

xfs_rmap_update_diff_items(
@@ -307,8 +264,40 @@ xfs_rmap_update_log_item( 
	map->me_startblock = ri->ri_bmap.br_startblock;

	map->me_startoff = ri->ri_bmap.br_startoff;

	map->me_len = ri->ri_bmap.br_blockcount;

	xfs_trans_set_rmap_flags(map, ri->ri_type, ri->ri_whichfork,

			ri->ri_bmap.br_state);



	map->me_flags = 0;

	if (ri->ri_bmap.br_state == XFS_EXT_UNWRITTEN)

		map->me_flags |= XFS_RMAP_EXTENT_UNWRITTEN;

	if (ri->ri_whichfork == XFS_ATTR_FORK)

		map->me_flags |= XFS_RMAP_EXTENT_ATTR_FORK;

	switch (ri->ri_type) {

	case XFS_RMAP_MAP:

		map->me_flags |= XFS_RMAP_EXTENT_MAP;

		break;

	case XFS_RMAP_MAP_SHARED:

		map->me_flags |= XFS_RMAP_EXTENT_MAP_SHARED;

		break;

	case XFS_RMAP_UNMAP:

		map->me_flags |= XFS_RMAP_EXTENT_UNMAP;

		break;

	case XFS_RMAP_UNMAP_SHARED:

		map->me_flags |= XFS_RMAP_EXTENT_UNMAP_SHARED;

		break;

	case XFS_RMAP_CONVERT:

		map->me_flags |= XFS_RMAP_EXTENT_CONVERT;

		break;

	case XFS_RMAP_CONVERT_SHARED:

		map->me_flags |= XFS_RMAP_EXTENT_CONVERT_SHARED;

		break;

	case XFS_RMAP_ALLOC:

		map->me_flags |= XFS_RMAP_EXTENT_ALLOC;

		break;

	case XFS_RMAP_FREE:

		map->me_flags |= XFS_RMAP_EXTENT_FREE;

		break;

	default:

		ASSERT(0);

	}

}



static struct xfs_log_item *