Commit c9163915 authored by David Gow's avatar David Gow Committed by Thomas Gleixner
Browse files

genirq/test: Fix depth tests on architectures with NOREQUEST by default. 



The new irq KUnit tests fail on some architectures (notably PowerPC and
32-bit ARM), as the request_irq() call fails due to the ARCH_IRQ_INIT_FLAGS
containing IRQ_NOREQUEST, yielding the following errors:

[10:17:45]     # irq_free_disabled_test: EXPECTATION FAILED at kernel/irq/irq_test.c:88
[10:17:45]     Expected ret == 0, but
[10:17:45]         ret == -22 (0xffffffffffffffea)
[10:17:45]     # irq_free_disabled_test: EXPECTATION FAILED at kernel/irq/irq_test.c:90
[10:17:45]     Expected desc->depth == 0, but
[10:17:45]         desc->depth == 1 (0x1)
[10:17:45]     # irq_free_disabled_test: EXPECTATION FAILED at kernel/irq/irq_test.c:93
[10:17:45]     Expected desc->depth == 1, but
[10:17:45]         desc->depth == 2 (0x2)

By clearing IRQ_NOREQUEST from the interrupt descriptor, these tests now
pass on ARM and PowerPC.

Fixes: 66067c3c ("genirq: Add kunit tests for depth counts")
Signed-off-by: default avatarDavid Gow <davidgow@google.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
Tested-by: default avatarBrian Norris <briannorris@chromium.org>
Reviewed-by: default avatarBrian Norris <briannorris@chromium.org>
Link: https://lore.kernel.org/all/20250816094528.3560222-2-davidgow@google.com
parent 673f1244

kernel/irq/irq_test.c

+12 −0
Original line number Diff line number Diff line
@@ -54,6 +54,9 @@ static void irq_disable_depth_test(struct kunit *test) 
	desc = irq_to_desc(virq);

	KUNIT_ASSERT_PTR_NE(test, desc, NULL);



	/* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */

	irq_settings_clr_norequest(desc);



	ret = request_irq(virq, noop_handler, 0, "test_irq", NULL);

	KUNIT_EXPECT_EQ(test, ret, 0);
@@ -81,6 +84,9 @@ static void irq_free_disabled_test(struct kunit *test) 
	desc = irq_to_desc(virq);

	KUNIT_ASSERT_PTR_NE(test, desc, NULL);



	/* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */

	irq_settings_clr_norequest(desc);



	ret = request_irq(virq, noop_handler, 0, "test_irq", NULL);

	KUNIT_EXPECT_EQ(test, ret, 0);
@@ -120,6 +126,9 @@ static void irq_shutdown_depth_test(struct kunit *test) 
	desc = irq_to_desc(virq);

	KUNIT_ASSERT_PTR_NE(test, desc, NULL);



	/* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */

	irq_settings_clr_norequest(desc);



	data = irq_desc_get_irq_data(desc);

	KUNIT_ASSERT_PTR_NE(test, data, NULL);
@@ -180,6 +189,9 @@ static void irq_cpuhotplug_test(struct kunit *test) 
	desc = irq_to_desc(virq);

	KUNIT_ASSERT_PTR_NE(test, desc, NULL);



	/* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */

	irq_settings_clr_norequest(desc);



	data = irq_desc_get_irq_data(desc);

	KUNIT_ASSERT_PTR_NE(test, data, NULL);