Commit c917e39c authored by Alex Deucher's avatar Alex Deucher
Browse files

drm/amdgpu/umsch: fix ucode check 



Return an error if the IP version doesn't match otherwise
we end up passing a NULL string to amdgpu_ucode_request.
We should never hit this in practice today since we only
enable the umsch code on the supported IP versions, but
add a check to be safe.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502130406.iWQ0eBug-lkp@intel.com/


Fixes: 02062042 ("drm/amd: Use a constant format string for amdgpu_ucode_request")
Reviewed-by: default avatarSaleemkhan Jamadar <saleemkhan.jamadar@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Lang Yu <Lang.Yu@amd.com>
parent 5183e690

drivers/gpu/drm/amd/amdgpu/amdgpu_umsch_mm.c

+1 −1
Original line number Diff line number Diff line
@@ -129,7 +129,7 @@ int amdgpu_umsch_mm_init_microcode(struct amdgpu_umsch_mm *umsch) 
		fw_name = "amdgpu/umsch_mm_4_0_0.bin";

		break;

	default:

		break;

		return -EINVAL;

	}



	r = amdgpu_ucode_request(adev, &adev->umsch_mm.fw, AMDGPU_UCODE_REQUIRED,