Commit c9363bbb authored by Jarosław Janik's avatar Jarosław Janik Committed by Takashi Iwai
Browse files

Revert "ALSA: hda/conexant: Mute speakers at suspend / shutdown" 



Commit 4f61c8fe ("ALSA: hda/conexant: Mute speakers at suspend /
shutdown") mutes speakers on system shutdown or whenever HDA controller
is suspended by PM; this however interacts badly with Thinkpad's ACPI
firmware behavior which uses beeps to signal various events (enter/leave
suspend or hibernation, AC power connect/disconnect, low battery, etc.);
now those beeps are either muted altogether (for suspend/hibernate/
shutdown related events) or work more or less randomly (eg. AC
plug/unplug is only audible when you are playing music at the moment,
because HDA device is likely in suspend mode otherwise).

Since the original bug report mentioned in 4f61c8fe complained about
Lenovo's Thinkpad laptop - revert this commit altogether.

Fixes: 4f61c8fe ("ALSA: hda/conexant: Mute speakers at suspend / shutdown")
Signed-off-by: default avatarJarosław Janik <jaroslaw.janik@gmail.com>
Link: https://patch.msgid.link/20241030171813.18941-2-jaroslaw.janik@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e49370d7

sound/pci/hda/patch_conexant.c

+0 −2
Original line number Diff line number Diff line
@@ -205,8 +205,6 @@ static void cx_auto_shutdown(struct hda_codec *codec) 
{

	struct conexant_spec *spec = codec->spec;



	snd_hda_gen_shutup_speakers(codec);



	/* Turn the problematic codec into D3 to avoid spurious noises

	   from the internal speaker during (and after) reboot */

	cx_auto_turn_eapd(codec, spec->num_eapds, spec->eapds, false);