Commit c94d1783 authored by Christian Marangi's avatar Christian Marangi Committed by Jakub Kicinski
Browse files

dt-bindings: net: phy: Make LED active-low property common 



Move LED active-low property to common.yaml. This property is currently
defined multiple times by bcm LEDs. This property will now be supported
in a generic way for PHY LEDs with the use of a generic function.

With active-low bool property not defined, active-high is always
assumed.

Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Acked-by: default avatarLee Jones <lee@kernel.org>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20240125203702.4552-2-ansuelsmth@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5642c82b

Documentation/devicetree/bindings/leds/common.yaml

+6 −0
Original line number Diff line number Diff line
@@ -200,6 +200,12 @@ properties: 
      #trigger-source-cells property in the source node.

    $ref: /schemas/types.yaml#/definitions/phandle-array



  active-low:

    type: boolean

    description:

      Makes LED active low. To turn the LED ON, line needs to be

      set to low voltage instead of high.



  # Required properties for flash LED child nodes:

  flash-max-microamp:

    description:

Documentation/devicetree/bindings/leds/leds-bcm63138.yaml

+0 −4
Original line number Diff line number Diff line
@@ -52,10 +52,6 @@ patternProperties: 
        maxItems: 1

        description: LED pin number



      active-low:

        type: boolean

        description: Makes LED active low



    required:

      - reg

Documentation/devicetree/bindings/leds/leds-bcm6328.yaml

+0 −4
Original line number Diff line number Diff line
@@ -78,10 +78,6 @@ patternProperties: 
          - maximum: 23

        description: LED pin number (only LEDs 0 to 23 are valid).



      active-low:

        type: boolean

        description: Makes LED active low.



      brcm,hardware-controlled:

        type: boolean

        description: Makes this LED hardware controlled.

Documentation/devicetree/bindings/leds/leds-bcm6358.txt

+0 −2
Original line number Diff line number Diff line
@@ -25,8 +25,6 @@ LED sub-node required properties: 


LED sub-node optional properties:

  - label : see Documentation/devicetree/bindings/leds/common.txt

  - active-low : Boolean, makes LED active low.

    Default : false

  - default-state : see

    Documentation/devicetree/bindings/leds/common.txt

  - linux,default-trigger : see

Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml

+0 −4
Original line number Diff line number Diff line
@@ -41,10 +41,6 @@ properties: 


          pwm-names: true



          active-low:

            description: For PWMs where the LED is wired to supply rather than ground.

            type: boolean



          color: true



        required: