Commit c9507eab authored by Asutosh Das's avatar Asutosh Das Committed by Martin K. Petersen
Browse files

scsi: ufs: mcq: qcom: Clean the return path of ufs_qcom_mcq_config_resource() 



Smatch static checker reported:
drivers/ufs/host/ufs-qcom.c:1469
ufs_qcom_mcq_config_resource() info: returning a literal zero is
cleaner

Fix the above warning by returning in place instead of a jump to a label.
Also remove the usage of devm_kfree() as it's unnecessary in this function.

Fixes: c263b4ef ("scsi: ufs: core: mcq: Configure resource regions")
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarAsutosh Das <quic_asutoshd@quicinc.com>
Link: https://lore.kernel.org/r/3ebd2582af74b81ef7b57149f57c6a3bf0963953.1677721229.git.quic_asutoshd@quicinc.com


Reviewed-by: default avatarBjorn Andersson <andersson@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <mani@kernel.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent c8be073b

drivers/ufs/host/ufs-qcom.c

+2 −4
Original line number Diff line number Diff line
@@ -1466,7 +1466,7 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba) 
	/* Explicitly allocate MCQ resource from ufs_mem */

	res_mcq = devm_kzalloc(hba->dev, sizeof(*res_mcq), GFP_KERNEL);

	if (!res_mcq)

		return ret;

		return -ENOMEM;



	res_mcq->start = res_mem->start +

			 MCQ_SQATTR_OFFSET(hba->mcq_capabilities);
@@ -1478,7 +1478,7 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba) 
	if (ret) {

		dev_err(hba->dev, "Failed to insert MCQ resource, err=%d\n",

			ret);

		goto insert_res_err;

		return ret;

	}



	res->base = devm_ioremap_resource(hba->dev, res_mcq);
@@ -1495,8 +1495,6 @@ static int ufs_qcom_mcq_config_resource(struct ufs_hba *hba) 
ioremap_err:

	res->base = NULL;

	remove_resource(res_mcq);

insert_res_err:

	devm_kfree(hba->dev, res_mcq);

	return ret;

}