Commit c957072d authored by Thorsten Blum's avatar Thorsten Blum Committed by Borislav Petkov (AMD)
Browse files

x86/platform/olpc: Replace strcpy() with strscpy() in xo15_sci_add() 

strcpy() has been deprecated¹ because it performs no bounds checking on the
destination buffer, which can lead to buffer overflows. Use the safer
strscpy() instead.

  ¹ https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy



Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20251124125455.5495-2-thorsten.blum@linux.dev
parent 6823f10d

arch/x86/platform/olpc/olpc-xo15-sci.c

+3 −2
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ 


#include <linux/device.h>

#include <linux/slab.h>

#include <linux/string.h>

#include <linux/workqueue.h>

#include <linux/power_supply.h>

#include <linux/olpc-ec.h>
@@ -144,8 +145,8 @@ static int xo15_sci_add(struct acpi_device *device) 
	if (!device)

		return -EINVAL;



	strcpy(acpi_device_name(device), XO15_SCI_DEVICE_NAME);

	strcpy(acpi_device_class(device), XO15_SCI_CLASS);

	strscpy(acpi_device_name(device), XO15_SCI_DEVICE_NAME);

	strscpy(acpi_device_class(device), XO15_SCI_CLASS);



	/* Get GPE bit assignment (EC events). */

	status = acpi_evaluate_integer(device->handle, "_GPE", NULL, &tmp);