Commit c9bd4a82 authored by Murad Masimov's avatar Murad Masimov Committed by Takashi Iwai
Browse files

ALSA: hda/cs8409: Fix possible NULL dereference 



If snd_hda_gen_add_kctl fails to allocate memory and returns NULL, then
NULL pointer dereference will occur in the next line.

Since dolphin_fixups function is a hda_fixup function which is not supposed
to return any errors, add simple check before dereference, ignore the fail.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 20e50772 ("ALSA: hda/cs8409: Add support for dolphin")
Signed-off-by: default avatarMurad Masimov <m.masimov@maxima.ru>
Link: https://patch.msgid.link/20241010221649.1305-1-m.masimov@maxima.ru


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ad6639f1

sound/pci/hda/patch_cs8409.c

+3 −2
Original line number Diff line number Diff line
@@ -1403,6 +1403,7 @@ void dolphin_fixups(struct hda_codec *codec, const struct hda_fixup *fix, int ac 
		kctrl = snd_hda_gen_add_kctl(&spec->gen, "Line Out Playback Volume",

					     &cs42l42_dac_volume_mixer);

		/* Update Line Out kcontrol template */

		if (kctrl)

			kctrl->private_value = HDA_COMPOSE_AMP_VAL_OFS(DOLPHIN_HP_PIN_NID, 3, CS8409_CODEC1,

					       HDA_OUTPUT, CS42L42_VOL_DAC) | HDA_AMP_VAL_MIN_MUTE;

		cs8409_enable_ur(codec, 0);