Commit c9c59da7 authored by Peng Fan's avatar Peng Fan Committed by Vinod Koul
Browse files

dmaengine: fsl-edma: cleanup chan after dma_async_device_unregister 



There is kernel dump when do module test:
sysfs: cannot create duplicate filename
/devices/platform/soc@0/44000000.bus/44000000.dma-controller/dma/dma0chan0
 __dma_async_device_channel_register+0x128/0x19c
 dma_async_device_register+0x150/0x454
 fsl_edma_probe+0x6cc/0x8a0
 platform_probe+0x68/0xc8

fsl_edma_cleanup_vchan will unlink vchan.chan.device_node, while
dma_async_device_unregister  needs the link to do
__dma_async_device_channel_unregister. So need move fsl_edma_cleanup_vchan
after dma_async_device_unregister to make sure channel could be freed.

So clean up chan after dma_async_device_unregister to address this.

Fixes: 6f93b93b ("dmaengine: fsl-edma: kill the tasklets upon exit")
Reviewed-by: default avatarFrank Li <Frank.Li@nxp.com>
Signed-off-by: default avatarPeng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/r/20250228071720.3780479-1-peng.fan@oss.nxp.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6ec29d40

drivers/dma/fsl-edma-main.c

+1 −1
Original line number Diff line number Diff line
@@ -802,9 +802,9 @@ static void fsl_edma_remove(struct platform_device *pdev) 
	struct fsl_edma_engine *fsl_edma = platform_get_drvdata(pdev);



	fsl_edma_irq_exit(pdev, fsl_edma);

	fsl_edma_cleanup_vchan(&fsl_edma->dma_dev);

	of_dma_controller_free(np);

	dma_async_device_unregister(&fsl_edma->dma_dev);

	fsl_edma_cleanup_vchan(&fsl_edma->dma_dev);

	fsl_disable_clocks(fsl_edma, fsl_edma->drvdata->dmamuxs);

}