Commit c9ec045f authored by Shree Ramamoorthy's avatar Shree Ramamoorthy Committed by Bartosz Golaszewski
Browse files

gpio: tps65219: Use existing kernel gpio macros 



Replace the user-defined macros with the equivalent kernel macros provided.

The user-defined macros serve the same purpose as the common kernel macros.
The user-defined macros rely on the inference that _IN corresponds to true
and _OUT is false.

Signed-off-by: default avatarShree Ramamoorthy <s-ramamoorthy@ti.com>
Link: https://lore.kernel.org/r/20241217204755.1011731-2-s-ramamoorthy@ti.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent 7cef813a

drivers/gpio/gpio-tps65219.c

+5 −7
Original line number Diff line number Diff line
@@ -15,8 +15,6 @@ 
#define TPS65219_GPIO0_DIR_MASK		BIT(3)

#define TPS65219_GPIO0_OFFSET		2

#define TPS65219_GPIO0_IDX		0

#define TPS65219_GPIO_DIR_IN		1

#define TPS65219_GPIO_DIR_OUT		0



struct tps65219_gpio {

	struct gpio_chip gpio_chip;
@@ -61,7 +59,7 @@ static int tps65219_gpio_get(struct gpio_chip *gc, unsigned int offset) 
	 * status bit.

	 */



	if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_OUT)

	if (tps65219_gpio_get_direction(gc, offset) == GPIO_LINE_DIRECTION_OUT)

		return -ENOTSUPP;



	return ret;
@@ -124,10 +122,10 @@ static int tps65219_gpio_direction_input(struct gpio_chip *gc, unsigned int offs 
		return -ENOTSUPP;

	}



	if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_IN)

	if (tps65219_gpio_get_direction(gc, offset) == GPIO_LINE_DIRECTION_IN)

		return 0;



	return tps65219_gpio_change_direction(gc, offset, TPS65219_GPIO_DIR_IN);

	return tps65219_gpio_change_direction(gc, offset, GPIO_LINE_DIRECTION_IN);

}



static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned int offset, int value)
@@ -136,10 +134,10 @@ static int tps65219_gpio_direction_output(struct gpio_chip *gc, unsigned int off 
	if (offset != TPS65219_GPIO0_IDX)

		return 0;



	if (tps65219_gpio_get_direction(gc, offset) == TPS65219_GPIO_DIR_OUT)

	if (tps65219_gpio_get_direction(gc, offset) == GPIO_LINE_DIRECTION_OUT)

		return 0;



	return tps65219_gpio_change_direction(gc, offset, TPS65219_GPIO_DIR_OUT);

	return tps65219_gpio_change_direction(gc, offset, GPIO_LINE_DIRECTION_OUT);

}



static const struct gpio_chip tps65219_template_chip = {