Commit c9f7b0e6 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

media: ccs: Discard pm_runtime_put() return value 



Passing the pm_runtime_put() return value to callers is not particularly
useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update ccs_post_streamoff() to simply discard the return
value of pm_runtime_put() and always return success to the caller.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Link: https://patch.msgid.link/22966634.EfDdHjke4D@rafael.j.wysocki
parent 88dcab06

drivers/media/i2c/ccs/ccs-core.c

+3 −1
Original line number Diff line number Diff line
@@ -1974,7 +1974,9 @@ static int ccs_post_streamoff(struct v4l2_subdev *subdev) 
	struct ccs_sensor *sensor = to_ccs_sensor(subdev);

	struct i2c_client *client = v4l2_get_subdevdata(&sensor->src->sd);



	return pm_runtime_put(&client->dev);

	pm_runtime_put(&client->dev);



	return 0;

}



static int ccs_enum_mbus_code(struct v4l2_subdev *subdev,