Commit ca00f7d9 authored by James Morse's avatar James Morse Committed by Greg Kroah-Hartman
Browse files

drivers: base: Print a warning instead of panic() when register_cpu() fails 



loongarch, mips, parisc, riscv and sh all print a warning if
register_cpu() returns an error. Architectures that use
GENERIC_CPU_DEVICES call panic() instead.

Errors in this path indicate something is wrong with the firmware
description of the platform, but the kernel is able to keep running.

Downgrade this to a warning to make it easier to debug this issue.

This will allow architectures that switching over to GENERIC_CPU_DEVICES
to drop their warning, but keep the existing behaviour.

Signed-off-by: default avatarJames Morse <james.morse@arm.com>
Reviewed-by: default avatar"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarShaoqin Huang <shahuang@redhat.com>
Signed-off-by: default avatar"Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarGavin Shan <gshan@redhat.com>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/E1r5R3W-00CszU-GM@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d631a881

drivers/base/cpu.c

+4 −3
Original line number Diff line number Diff line
@@ -551,14 +551,15 @@ void __weak arch_unregister_cpu(int num) 


static void __init cpu_dev_register_generic(void)

{

	int i;

	int i, ret;



	if (!IS_ENABLED(CONFIG_GENERIC_CPU_DEVICES))

		return;



	for_each_present_cpu(i) {

		if (arch_register_cpu(i))

			panic("Failed to register CPU device");

		ret = arch_register_cpu(i);

		if (ret)

			pr_warn("register_cpu %d failed (%d)\n", i, ret);

	}

}