Commit ca16b15e authored by Alexandre Courbot's avatar Alexandre Courbot
Browse files

gpu: nova-core: bitfield: remove BitOr implementation 



Using this operand can produce invalid values. It also doesn't bring
any benefit as one can use the builder pattern to assemble a new value.

Reported-by: default avatarEdwin Peer <epeer@nvidia.com>
Link: https://lore.kernel.org/rust-for-linux/F3853912-2C1C-4F9B-89B0-3168689F35B3@nvidia.com/


Reviewed-by: default avatarJoel Fernandes <joelagnelf@nvidia.com>
Reviewed-by: default avatarDanilo Krummrich <dakr@kernel.org>
Signed-off-by: default avatarAlexandre Courbot <acourbot@nvidia.com>
Message-ID: <20251022-nova-bitfield-v1-3-73bc0988667b@nvidia.com>
parent e6b8932b

drivers/gpu/nova-core/bitfield.rs

+1 −9
Original line number Diff line number Diff line
@@ -94,7 +94,7 @@ macro_rules! bitfield { 
    // All rules below are helpers.



    // Defines the wrapper `$name` type, as well as its relevant implementations (`Debug`,

    // `Default`, `BitOr`, and conversion to the value type) and field accessor methods.

    // `Default`, and conversion to the value type) and field accessor methods.

    (@core $vis:vis $name:ident $storage:ty $(, $comment:literal)? { $($fields:tt)* }) => {

        $(

        #[doc=$comment]
@@ -103,14 +103,6 @@ macro_rules! bitfield { 
        #[derive(Clone, Copy)]

        $vis struct $name($storage);



        impl ::core::ops::BitOr for $name {

            type Output = Self;



            fn bitor(self, rhs: Self) -> Self::Output {

                Self(self.0 | rhs.0)

            }

        }



        impl ::core::convert::From<$name> for $storage {

            fn from(val: $name) -> $storage {

                val.0