Commit ca34ee6d authored by Sanman Pradhan's avatar Sanman Pradhan Committed by Guenter Roeck
Browse files

hwmon: (tps53679) Fix device ID comparison and printing in tps53676_identify() 



tps53676_identify() uses strncmp() to compare the device ID buffer
against a byte sequence containing embedded non-printable bytes
(\x53\x67\x60). strncmp() is semantically wrong for binary data
comparison; use memcmp() instead.

Additionally, the buffer from i2c_smbus_read_block_data() is not
NUL-terminated, so printing it with "%s" in the error path is
undefined behavior and may read past the buffer. Use "%*ph" to
hex-dump the actual bytes returned.

Per the datasheet, the expected device ID is the 6-byte sequence
54 49 53 67 60 00 ("TI\x53\x67\x60\x00"), so compare all 6 bytes
including the trailing NUL.

Fixes: cb3d37b5 ("hwmon: (pmbus/tps53679) Add support for TI TPS53676")
Signed-off-by: default avatarSanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260330155618.77403-1-sanman.pradhan@hpe.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a9d2fbd3

drivers/hwmon/pmbus/tps53679.c

+2 −2
Original line number Diff line number Diff line
@@ -175,8 +175,8 @@ static int tps53676_identify(struct i2c_client *client, 
	ret = i2c_smbus_read_block_data(client, PMBUS_IC_DEVICE_ID, buf);

	if (ret < 0)

		return ret;

	if (strncmp("TI\x53\x67\x60", buf, 5)) {

		dev_err(&client->dev, "Unexpected device ID: %s\n", buf);

	if (ret != 6 || memcmp(buf, "TI\x53\x67\x60\x00", 6)) {

		dev_err(&client->dev, "Unexpected device ID: %*ph\n", ret, buf);

		return -ENODEV;

	}