Commit ca43b74a authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Carlos Maiolino
Browse files

xfs: remove some EXPERIMENTAL warnings 



Online fsck was finished a year ago, in Linux 6.10.  The exchange-range
syscall and parent pointers were merged in the same cycle.  None of
these have encountered any serious errors in the year that they've been
in the kernel (or the many many years they've been under development) so
let's drop the shouty warnings.

Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarCarlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent 6e7d71b3

fs/xfs/scrub/scrub.c

+0 −2
Original line number Diff line number Diff line
@@ -680,8 +680,6 @@ xfs_scrub_metadata( 
	if (error)

		goto out;



	xfs_warn_experimental(mp, XFS_EXPERIMENTAL_SCRUB);



	sc = kzalloc(sizeof(struct xfs_scrub), XCHK_GFP_FLAGS);

	if (!sc) {

		error = -ENOMEM;

fs/xfs/xfs_message.c

+0 −12
Original line number Diff line number Diff line
@@ -145,10 +145,6 @@ xfs_warn_experimental( 
			.opstate	= XFS_OPSTATE_WARNED_PNFS,

			.name		= "pNFS",

		},

		[XFS_EXPERIMENTAL_SCRUB] = {

			.opstate	= XFS_OPSTATE_WARNED_SCRUB,

			.name		= "online scrub",

		},

		[XFS_EXPERIMENTAL_SHRINK] = {

			.opstate	= XFS_OPSTATE_WARNED_SHRINK,

			.name		= "online shrink",
@@ -161,14 +157,6 @@ xfs_warn_experimental( 
			.opstate	= XFS_OPSTATE_WARNED_LBS,

			.name		= "large block size",

		},

		[XFS_EXPERIMENTAL_EXCHRANGE] = {

			.opstate	= XFS_OPSTATE_WARNED_EXCHRANGE,

			.name		= "exchange range",

		},

		[XFS_EXPERIMENTAL_PPTR] = {

			.opstate	= XFS_OPSTATE_WARNED_PPTR,

			.name		= "parent pointer",

		},

		[XFS_EXPERIMENTAL_METADIR] = {

			.opstate	= XFS_OPSTATE_WARNED_METADIR,

			.name		= "metadata directory tree",

fs/xfs/xfs_message.h

+0 −3
Original line number Diff line number Diff line
@@ -92,12 +92,9 @@ void xfs_buf_alert_ratelimited(struct xfs_buf *bp, const char *rlmsg, 


enum xfs_experimental_feat {

	XFS_EXPERIMENTAL_PNFS,

	XFS_EXPERIMENTAL_SCRUB,

	XFS_EXPERIMENTAL_SHRINK,

	XFS_EXPERIMENTAL_LARP,

	XFS_EXPERIMENTAL_LBS,

	XFS_EXPERIMENTAL_EXCHRANGE,

	XFS_EXPERIMENTAL_PPTR,

	XFS_EXPERIMENTAL_METADIR,

	XFS_EXPERIMENTAL_ZONED,

fs/xfs/xfs_mount.h

+0 −7
Original line number Diff line number Diff line
@@ -559,8 +559,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID) 


/* Kernel has logged a warning about pNFS being used on this fs. */

#define XFS_OPSTATE_WARNED_PNFS		7

/* Kernel has logged a warning about online fsck being used on this fs. */

#define XFS_OPSTATE_WARNED_SCRUB	8

/* Kernel has logged a warning about shrink being used on this fs. */

#define XFS_OPSTATE_WARNED_SHRINK	9

/* Kernel has logged a warning about logged xattr updates being used. */
@@ -573,10 +571,6 @@ __XFS_HAS_FEAT(nouuid, NOUUID) 
#define XFS_OPSTATE_USE_LARP		13

/* Kernel has logged a warning about blocksize > pagesize on this fs. */

#define XFS_OPSTATE_WARNED_LBS		14

/* Kernel has logged a warning about exchange-range being used on this fs. */

#define XFS_OPSTATE_WARNED_EXCHRANGE	15

/* Kernel has logged a warning about parent pointers being used on this fs. */

#define XFS_OPSTATE_WARNED_PPTR		16

/* Kernel has logged a warning about metadata dirs being used on this fs. */

#define XFS_OPSTATE_WARNED_METADIR	17

/* Filesystem should use qflags to determine quotaon status */
@@ -645,7 +639,6 @@ xfs_should_warn(struct xfs_mount *mp, long nr) 
	{ (1UL << XFS_OPSTATE_READONLY),		"read_only" }, \

	{ (1UL << XFS_OPSTATE_INODEGC_ENABLED),		"inodegc" }, \

	{ (1UL << XFS_OPSTATE_BLOCKGC_ENABLED),		"blockgc" }, \

	{ (1UL << XFS_OPSTATE_WARNED_SCRUB),		"wscrub" }, \

	{ (1UL << XFS_OPSTATE_WARNED_SHRINK),		"wshrink" }, \

	{ (1UL << XFS_OPSTATE_WARNED_LARP),		"wlarp" }, \

	{ (1UL << XFS_OPSTATE_QUOTACHECK_RUNNING),	"quotacheck" }, \

fs/xfs/xfs_super.c

+0 −7
Original line number Diff line number Diff line
@@ -1954,13 +1954,6 @@ xfs_fs_fill_super( 
		}

	}





	if (xfs_has_exchange_range(mp))

		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_EXCHRANGE);



	if (xfs_has_parent(mp))

		xfs_warn_experimental(mp, XFS_EXPERIMENTAL_PPTR);



	/*

	 * If no quota mount options were provided, maybe we'll try to pick

	 * up the quota accounting and enforcement flags from the ondisk sb.