Commit ca545b7f authored Apr 02, 2024 by Paulo Alcantara Committed by Steve French Apr 03, 2024

smb: client: fix potential UAF in cifs_debug_files_proc_show()



Skip sessions that are being teared down (status == SES_EXITING) to
avoid UAF.

Cc: stable@vger.kernel.org
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>

parent 173217bd

fs/smb/client/cifs_debug.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -250,6 +250,8 @@ static int cifs_debug_files_proc_show(struct seq_file m, void v)
		spin_lock(&cifs_tcp_ses_lock);
		list_for_each_entry(server, &cifs_tcp_ses_list, tcp_ses_list) {
		list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
		if (cifs_ses_exiting(ses))
		continue;
		list_for_each_entry(tcon, &ses->tcon_list, tcon_list) {
		spin_lock(&tcon->open_file_lock);
		list_for_each_entry(cfile, &tcon->openFileList, tlist) {

fs/smb/client/cifsglob.h

+10 −0

Original line number	Diff line number	Diff line
		@@ -2325,4 +2325,14 @@ struct smb2_compound_vars {
		struct kvec ea_iov;
		};

		static inline bool cifs_ses_exiting(struct cifs_ses *ses)
		{
		bool ret;

		spin_lock(&ses->ses_lock);
		ret = ses->ses_status == SES_EXITING;
		spin_unlock(&ses->ses_lock);
		return ret;
		}

		#endif /* _CIFS_GLOB_H */