Commit ca81109d authored by Zilin Guan's avatar Zilin Guan Committed by Theodore Ts'o
Browse files

ext4: fix memory leak in ext4_ext_shift_extents() 



In ext4_ext_shift_extents(), if the extent is NULL in the while loop, the
function returns immediately without releasing the path obtained via
ext4_find_extent(), leading to a memory leak.

Fix this by jumping to the out label to ensure the path is properly
released.

Fixes: a18ed359 ("ext4: always check ext4_ext_find_extent result")
Signed-off-by: default avatarZilin Guan <zilin@seu.edu.cn>
Reviewed-by: default avatarZhang Yi <yi.zhang@huawei.com>
Reviewed-by: default avatarBaokun Li <libaokun1@huawei.com>
Link: https://patch.msgid.link/20251225084800.905701-1-zilin@seu.edu.cn


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
parent 154922b3

fs/ext4/extents.c

+2 −1
Original line number Diff line number Diff line
@@ -5406,7 +5406,8 @@ ext4_ext_shift_extents(struct inode *inode, handle_t *handle, 
		if (!extent) {

			EXT4_ERROR_INODE(inode, "unexpected hole at %lu",

					 (unsigned long) *iterator);

			return -EFSCORRUPTED;

			ret = -EFSCORRUPTED;

			goto out;

		}

		if (SHIFT == SHIFT_LEFT && *iterator >

		    le32_to_cpu(extent->ee_block)) {