Commit cab63f64 authored by Dinghao Liu's avatar Dinghao Liu Committed by Alexandre Belloni
Browse files

i3c: Fix potential refcount leak in i3c_master_register_new_i3c_devs 



put_device() needs to be called on failure of device_register()
to give up the reference initialized in it to avoid refcount leak.

Fixes: 3a379bbc ("i3c: Add core I3C infrastructure")
Signed-off-by: default avatarDinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20230921082410.25548-1-dinghao.liu@zju.edu.cn


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent fc9176e7

drivers/i3c/master.c

+3 −1
Original line number Diff line number Diff line
@@ -1525,9 +1525,11 @@ i3c_master_register_new_i3c_devs(struct i3c_master_controller *master) 
			desc->dev->dev.of_node = desc->boardinfo->of_node;



		ret = device_register(&desc->dev->dev);

		if (ret)

		if (ret) {

			dev_err(&master->dev,

				"Failed to add I3C device (err = %d)\n", ret);

			put_device(&desc->dev->dev);

		}

	}

}