Unverified Commit cacbce45 authored by Colin Ian King's avatar Colin Ian King Committed by Mark Brown
Browse files

ASoC: rockchip: i2s-tdm: Fix error handling on i2s_tdm_prepare_enable_mclk failure 



In the case where the call to i2s_tdm_prepare_enable_mclk fails the
function returns before the error handling goto is executed. Fix this
by removing the return do perform the intended error handling exit.

Fixes: 081068fd ("ASoC: rockchip: add support for i2s-tdm controller")
Addresses-Coverity: ("Structurally dead code")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Message-Id: <20211008095430.62680-2-colin.king@canonical.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 74daadc7

sound/soc/rockchip/rockchip_i2s_tdm.c

+2 −2
Original line number Diff line number Diff line
@@ -1736,7 +1736,7 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev) 


	ret = i2s_tdm_prepare_enable_mclk(i2s_tdm);

	if (ret) {

		return dev_err_probe(i2s_tdm->dev, ret,

		ret = dev_err_probe(i2s_tdm->dev, ret,

				    "Failed to enable one or more mclks\n");

		goto err_disable_hclk;

	}