Commit cb16f4b6 authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by Jakub Kicinski
Browse files

tcp: Don't pass hashinfo to socket lookup helpers. 



These socket lookup functions required struct inet_hashinfo because
they are shared by TCP and DCCP.

  * __inet_lookup_established()
  * __inet_lookup_listener()
  * __inet6_lookup_established()
  * inet6_lookup_listener()

DCCP has gone, and we don't need to pass hashinfo down to them.

Let's fetch net->ipv4.tcp_death_row.hashinfo directly in the above
4 functions.

Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250822190803.540788-5-kuniyu@google.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8150f3a4

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_rx.c

+4 −5
Original line number Diff line number Diff line
@@ -498,9 +498,9 @@ static void resync_update_sn(struct mlx5e_rq *rq, struct sk_buff *skb) 
		depth += sizeof(struct iphdr);

		th = (void *)iph + sizeof(struct iphdr);



		sk = inet_lookup_established(net, net->ipv4.tcp_death_row.hashinfo,

					     iph->saddr, th->source, iph->daddr,

					     th->dest, netdev->ifindex);

		sk = inet_lookup_established(net, iph->saddr, th->source,

					     iph->daddr, th->dest,

					     netdev->ifindex);

#if IS_ENABLED(CONFIG_IPV6)

	} else {

		struct ipv6hdr *ipv6h = (struct ipv6hdr *)iph;
@@ -508,8 +508,7 @@ static void resync_update_sn(struct mlx5e_rq *rq, struct sk_buff *skb) 
		depth += sizeof(struct ipv6hdr);

		th = (void *)ipv6h + sizeof(struct ipv6hdr);



		sk = __inet6_lookup_established(net, net->ipv4.tcp_death_row.hashinfo,

						&ipv6h->saddr, th->source,

		sk = __inet6_lookup_established(net, &ipv6h->saddr, th->source,

						&ipv6h->daddr, ntohs(th->dest),

						netdev->ifindex, 0);

#endif

drivers/net/ethernet/netronome/nfp/crypto/tls.c

+4 −5
Original line number Diff line number Diff line
@@ -495,14 +495,13 @@ int nfp_net_tls_rx_resync_req(struct net_device *netdev, 


	switch (ipv6h->version) {

	case 4:

		sk = inet_lookup_established(net, net->ipv4.tcp_death_row.hashinfo,

					     iph->saddr, th->source, iph->daddr,

					     th->dest, netdev->ifindex);

		sk = inet_lookup_established(net, iph->saddr, th->source,

					     iph->daddr, th->dest,

					     netdev->ifindex);

		break;

#if IS_ENABLED(CONFIG_IPV6)

	case 6:

		sk = __inet6_lookup_established(net, net->ipv4.tcp_death_row.hashinfo,

						&ipv6h->saddr, th->source,

		sk = __inet6_lookup_established(net, &ipv6h->saddr, th->source,

						&ipv6h->daddr, ntohs(th->dest),

						netdev->ifindex, 0);

		break;

include/net/inet6_hashtables.h

+6 −12
Original line number Diff line number Diff line
@@ -41,7 +41,6 @@ static inline unsigned int __inet6_ehashfn(const u32 lhash, 
 * The sockhash lock must be held as a reader here.

 */

struct sock *__inet6_lookup_established(const struct net *net,

					struct inet_hashinfo *hashinfo,

					const struct in6_addr *saddr,

					const __be16 sport,

					const struct in6_addr *daddr,
@@ -65,7 +64,6 @@ struct sock *inet6_lookup_reuseport(const struct net *net, struct sock *sk, 
				    inet6_ehashfn_t *ehashfn);



struct sock *inet6_lookup_listener(const struct net *net,

				   struct inet_hashinfo *hashinfo,

				   struct sk_buff *skb, int doff,

				   const struct in6_addr *saddr,

				   const __be16 sport,
@@ -83,7 +81,6 @@ struct sock *inet6_lookup_run_sk_lookup(const struct net *net, 
					inet6_ehashfn_t *ehashfn);



static inline struct sock *__inet6_lookup(const struct net *net,

					  struct inet_hashinfo *hashinfo,

					  struct sk_buff *skb, int doff,

					  const struct in6_addr *saddr,

					  const __be16 sport,
@@ -92,14 +89,14 @@ static inline struct sock *__inet6_lookup(const struct net *net, 
					  const int dif, const int sdif,

					  bool *refcounted)

{

	struct sock *sk = __inet6_lookup_established(net, hashinfo, saddr,

						     sport, daddr, hnum,

	struct sock *sk = __inet6_lookup_established(net, saddr, sport,

						     daddr, hnum,

						     dif, sdif);

	*refcounted = true;

	if (sk)

		return sk;

	*refcounted = false;

	return inet6_lookup_listener(net, hashinfo, skb, doff, saddr, sport,

	return inet6_lookup_listener(net, skb, doff, saddr, sport,

				     daddr, hnum, dif, sdif);

}
@@ -143,8 +140,7 @@ struct sock *inet6_steal_sock(struct net *net, struct sk_buff *skb, int doff, 
	return reuse_sk;

}



static inline struct sock *__inet6_lookup_skb(struct inet_hashinfo *hashinfo,

					      struct sk_buff *skb, int doff,

static inline struct sock *__inet6_lookup_skb(struct sk_buff *skb, int doff,

					      const __be16 sport,

					      const __be16 dport,

					      int iif, int sdif,
@@ -161,14 +157,12 @@ static inline struct sock *__inet6_lookup_skb(struct inet_hashinfo *hashinfo, 
	if (sk)

		return sk;



	return __inet6_lookup(net, hashinfo, skb,

			      doff, &ip6h->saddr, sport,

	return __inet6_lookup(net, skb, doff, &ip6h->saddr, sport,

			      &ip6h->daddr, ntohs(dport),

			      iif, sdif, refcounted);

}



struct sock *inet6_lookup(const struct net *net, struct inet_hashinfo *hashinfo,

			  struct sk_buff *skb, int doff,

struct sock *inet6_lookup(const struct net *net, struct sk_buff *skb, int doff,

			  const struct in6_addr *saddr, const __be16 sport,

			  const struct in6_addr *daddr, const __be16 dport,

			  const int dif);

include/net/inet_hashtables.h

+15 −22
Original line number Diff line number Diff line
@@ -294,7 +294,6 @@ int inet_hash(struct sock *sk); 
void inet_unhash(struct sock *sk);



struct sock *__inet_lookup_listener(const struct net *net,

				    struct inet_hashinfo *hashinfo,

				    struct sk_buff *skb, int doff,

				    const __be32 saddr, const __be16 sport,

				    const __be32 daddr,
@@ -302,12 +301,12 @@ struct sock *__inet_lookup_listener(const struct net *net, 
				    const int dif, const int sdif);



static inline struct sock *inet_lookup_listener(struct net *net,

		struct inet_hashinfo *hashinfo,

						struct sk_buff *skb, int doff,

						__be32 saddr, __be16 sport,

		__be32 daddr, __be16 dport, int dif, int sdif)

						__be32 daddr, __be16 dport,

						int dif, int sdif)

{

	return __inet_lookup_listener(net, hashinfo, skb, doff, saddr, sport,

	return __inet_lookup_listener(net, skb, doff, saddr, sport,

				      daddr, ntohs(dport), dif, sdif);

}
@@ -358,7 +357,6 @@ static inline bool inet_match(const struct net *net, const struct sock *sk, 
 * not check it for lookups anymore, thanks Alexey. -DaveM

 */

struct sock *__inet_lookup_established(const struct net *net,

				       struct inet_hashinfo *hashinfo,

				       const __be32 saddr, const __be16 sport,

				       const __be32 daddr, const u16 hnum,

				       const int dif, const int sdif);
@@ -384,18 +382,16 @@ struct sock *inet_lookup_run_sk_lookup(const struct net *net, 
				       __be32 daddr, u16 hnum, const int dif,

				       inet_ehashfn_t *ehashfn);



static inline struct sock *

	inet_lookup_established(struct net *net, struct inet_hashinfo *hashinfo,

static inline struct sock *inet_lookup_established(struct net *net,

						   const __be32 saddr, const __be16 sport,

						   const __be32 daddr, const __be16 dport,

						   const int dif)

{

	return __inet_lookup_established(net, hashinfo, saddr, sport, daddr,

	return __inet_lookup_established(net, saddr, sport, daddr,

					 ntohs(dport), dif, 0);

}



static inline struct sock *__inet_lookup(struct net *net,

					 struct inet_hashinfo *hashinfo,

					 struct sk_buff *skb, int doff,

					 const __be32 saddr, const __be16 sport,

					 const __be32 daddr, const __be16 dport,
@@ -405,18 +401,17 @@ static inline struct sock *__inet_lookup(struct net *net, 
	u16 hnum = ntohs(dport);

	struct sock *sk;



	sk = __inet_lookup_established(net, hashinfo, saddr, sport,

	sk = __inet_lookup_established(net, saddr, sport,

				       daddr, hnum, dif, sdif);

	*refcounted = true;

	if (sk)

		return sk;

	*refcounted = false;

	return __inet_lookup_listener(net, hashinfo, skb, doff, saddr,

	return __inet_lookup_listener(net, skb, doff, saddr,

				      sport, daddr, hnum, dif, sdif);

}



static inline struct sock *inet_lookup(struct net *net,

				       struct inet_hashinfo *hashinfo,

				       struct sk_buff *skb, int doff,

				       const __be32 saddr, const __be16 sport,

				       const __be32 daddr, const __be16 dport,
@@ -425,7 +420,7 @@ static inline struct sock *inet_lookup(struct net *net, 
	struct sock *sk;

	bool refcounted;



	sk = __inet_lookup(net, hashinfo, skb, doff, saddr, sport, daddr,

	sk = __inet_lookup(net, skb, doff, saddr, sport, daddr,

			   dport, dif, 0, &refcounted);



	if (sk && !refcounted && !refcount_inc_not_zero(&sk->sk_refcnt))
@@ -473,8 +468,7 @@ struct sock *inet_steal_sock(struct net *net, struct sk_buff *skb, int doff, 
	return reuse_sk;

}



static inline struct sock *__inet_lookup_skb(struct inet_hashinfo *hashinfo,

					     struct sk_buff *skb,

static inline struct sock *__inet_lookup_skb(struct sk_buff *skb,

					     int doff,

					     const __be16 sport,

					     const __be16 dport,
@@ -492,8 +486,7 @@ static inline struct sock *__inet_lookup_skb(struct inet_hashinfo *hashinfo, 
	if (sk)

		return sk;



	return __inet_lookup(net, hashinfo, skb,

			     doff, iph->saddr, sport,

	return __inet_lookup(net, skb, doff, iph->saddr, sport,

			     iph->daddr, dport, inet_iif(skb), sdif,

			     refcounted);

}

net/core/filter.c

+2 −3
Original line number Diff line number Diff line
@@ -6767,7 +6767,6 @@ static const struct bpf_func_proto bpf_lwt_seg6_adjust_srh_proto = { 
static struct sock *sk_lookup(struct net *net, struct bpf_sock_tuple *tuple,

			      int dif, int sdif, u8 family, u8 proto)

{

	struct inet_hashinfo *hinfo = net->ipv4.tcp_death_row.hashinfo;

	bool refcounted = false;

	struct sock *sk = NULL;
@@ -6776,7 +6775,7 @@ static struct sock *sk_lookup(struct net *net, struct bpf_sock_tuple *tuple, 
		__be32 dst4 = tuple->ipv4.daddr;



		if (proto == IPPROTO_TCP)

			sk = __inet_lookup(net, hinfo, NULL, 0,

			sk = __inet_lookup(net, NULL, 0,

					   src4, tuple->ipv4.sport,

					   dst4, tuple->ipv4.dport,

					   dif, sdif, &refcounted);
@@ -6790,7 +6789,7 @@ static struct sock *sk_lookup(struct net *net, struct bpf_sock_tuple *tuple, 
		struct in6_addr *dst6 = (struct in6_addr *)&tuple->ipv6.daddr;



		if (proto == IPPROTO_TCP)

			sk = __inet6_lookup(net, hinfo, NULL, 0,

			sk = __inet6_lookup(net, NULL, 0,

					    src6, tuple->ipv6.sport,

					    dst6, ntohs(tuple->ipv6.dport),

					    dif, sdif, &refcounted);