Commit cb1b78f1 authored by Dexuan Cui's avatar Dexuan Cui Committed by Wei Liu
Browse files

tools: hv: Fix a complier warning in the fcopy uio daemon 



hv_fcopy_uio_daemon.c:436:53: warning: '%s' directive output may be truncated
writing up to 14 bytes into a region of size 10 [-Wformat-truncation=]
  436 |  snprintf(uio_dev_path, sizeof(uio_dev_path), "/dev/%s", uio_name);

Also added 'static' for the array 'desc[]'.

Fixes: 82b0945c ("tools: hv: Add new fcopy application based on uio driver")
Cc: stable@vger.kernel.org # 6.10+
Signed-off-by: default avatarDexuan Cui <decui@microsoft.com>
Reviewed-by: default avatarSaurabh Sengar <ssengar@linux.microsoft.com>
Link: https://lore.kernel.org/r/20240910004433.50254-1-decui@microsoft.com


Signed-off-by: default avatarWei Liu <wei.liu@kernel.org>
Message-ID: <20240910004433.50254-1-decui@microsoft.com>
parent fac04efc

tools/hv/hv_fcopy_uio_daemon.c

+3 −5
Original line number Diff line number Diff line
@@ -35,8 +35,6 @@ 
#define WIN8_SRV_MINOR		1

#define WIN8_SRV_VERSION	(WIN8_SRV_MAJOR << 16 | WIN8_SRV_MINOR)



#define MAX_FOLDER_NAME		15

#define MAX_PATH_LEN		15

#define FCOPY_UIO		"/sys/bus/vmbus/devices/eb765408-105f-49b6-b4aa-c123b64d17d4/uio"



#define FCOPY_VER_COUNT		1
@@ -51,7 +49,7 @@ static const int fw_versions[] = { 


#define HV_RING_SIZE		0x4000 /* 16KB ring buffer size */



unsigned char desc[HV_RING_SIZE];

static unsigned char desc[HV_RING_SIZE];



static int target_fd;

static char target_fname[PATH_MAX];
@@ -409,8 +407,8 @@ int main(int argc, char *argv[]) 
	struct vmbus_br txbr, rxbr;

	void *ring;

	uint32_t len = HV_RING_SIZE;

	char uio_name[MAX_FOLDER_NAME] = {0};

	char uio_dev_path[MAX_PATH_LEN] = {0};

	char uio_name[NAME_MAX] = {0};

	char uio_dev_path[PATH_MAX] = {0};



	static struct option long_options[] = {

		{"help",	no_argument,	   0,  'h' },