Commit cb1bdf07 authored by Purva Yeshi's avatar Purva Yeshi Committed by Jens Axboe
Browse files

block: floppy: Fix uninitialized use of outparam 



Fix Smatch-detected error:
drivers/block/floppy.c:3569 fd_locked_ioctl() error:
uninitialized symbol 'outparam'.

Smatch may incorrectly warn about uninitialized use of 'outparam'
in fd_locked_ioctl(), even though all _IOC_READ commands guarantee
its initialization. Initialize outparam to NULL to make this explicit
and suppress the false positive.

Signed-off-by: default avatarPurva Yeshi <purvayeshi550@gmail.com>
Reviewed-by: default avatarDenis Efremov <efremov@linux.com>
Link: https://lore.kernel.org/r/20250713070020.14530-1-purvayeshi550@gmail.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7e495382

drivers/block/floppy.c

+1 −1
Original line number Diff line number Diff line
@@ -3411,7 +3411,7 @@ static int fd_locked_ioctl(struct block_device *bdev, blk_mode_t mode, 
		struct floppy_max_errors max_errors;

		struct floppy_drive_params dp;

	} inparam;		/* parameters coming from user space */

	const void *outparam;	/* parameters passed back to user space */

	const void *outparam = NULL;	/* parameters passed back to user space */



	/* convert compatibility eject ioctls into floppy eject ioctl.

	 * We do this in order to provide a means to eject floppy disks before