Commit cb1f868c authored by José Roberto de Souza's avatar José Roberto de Souza Committed by Lucas De Marchi
Browse files

drm/xe: Make GUC binaries dump consistent with other binaries in devcoredump 



All other(hwsp, hwctx and vmas) binaries follow this format:
[name].length: 0x1000
[name].data: xxxxxxx
[name].error: errno

The error one is just in case by some reason it was not able to
capture the binary.

So this GuC binaries should follow the same patern.

v2:
- renamed GUC binary to LOG

Cc: John Harrison <John.C.Harrison@Intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: default avatarJosé Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250123202307.95103-3-jose.souza@intel.com


Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent 2c95bbf5

drivers/gpu/drm/xe/xe_guc_ct.c

+4 −2
Original line number Diff line number Diff line
@@ -1723,9 +1723,11 @@ void xe_guc_ct_snapshot_print(struct xe_guc_ct_snapshot *snapshot, 
		drm_printf(p, "\tg2h outstanding: %d\n",

			   snapshot->g2h_outstanding);



		if (snapshot->ctb)

			xe_print_blob_ascii85(p, "CTB data", '\n',

		if (snapshot->ctb) {

			drm_printf(p, "[CTB].length: 0x%lx\n", snapshot->ctb_size);

			xe_print_blob_ascii85(p, "[CTB].data", '\n',

					      snapshot->ctb, 0, snapshot->ctb_size);

		}

	} else {

		drm_puts(p, "CT disabled\n");

	}

drivers/gpu/drm/xe/xe_guc_log.c

+2 −1
Original line number Diff line number Diff line
@@ -204,10 +204,11 @@ void xe_guc_log_snapshot_print(struct xe_guc_log_snapshot *snapshot, struct drm_ 
	drm_printf(p, "GuC timestamp: 0x%08llX [%llu]\n", snapshot->stamp, snapshot->stamp);

	drm_printf(p, "Log level: %u\n", snapshot->level);



	drm_printf(p, "[LOG].length: 0x%lx\n", snapshot->size);

	remain = snapshot->size;

	for (i = 0; i < snapshot->num_chunks; i++) {

		size_t size = min(GUC_LOG_CHUNK_SIZE, remain);

		const char *prefix = i ? NULL : "Log data";

		const char *prefix = i ? NULL : "[LOG].data";

		char suffix = i == snapshot->num_chunks - 1 ? '\n' : 0;



		xe_print_blob_ascii85(p, prefix, suffix, snapshot->copy[i], 0, size);