Commit cb372a50 authored by Ian Forbes's avatar Ian Forbes Committed by Zack Rusin
Browse files

drm/vmwgfx: Fix overlay when using Screen Targets 



This code was never updated to support Screen Targets.
Fixes a bug where Xv playback displays a green screen instead of actual
video contents when 3D acceleration is disabled in the guest.

Fixes: c8261a96 ("vmwgfx: Major KMS refactoring / cleanup in preparation of screen targets")
Reported-by: default avatarDoug Brown <doug@schmorgal.com>
Closes: https://lore.kernel.org/all/bd9cb3c7-90e8-435d-bc28-0e38fee58977@schmorgal.com


Signed-off-by: default avatarIan Forbes <ian.forbes@broadcom.com>
Tested-by: default avatarDoug Brown <doug@schmorgal.com>
Signed-off-by: default avatarZack Rusin <zack.rusin@broadcom.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240719163627.20888-1-ian.forbes@broadcom.com
parent 12bed149

drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c

+1 −1
Original line number Diff line number Diff line
@@ -92,7 +92,7 @@ static int vmw_overlay_send_put(struct vmw_private *dev_priv, 
{

	struct vmw_escape_video_flush *flush;

	size_t fifo_size;

	bool have_so = (dev_priv->active_display_unit == vmw_du_screen_object);

	bool have_so = (dev_priv->active_display_unit != vmw_du_legacy);

	int i, num_items;

	SVGAGuestPtr ptr;