Commit cb45e3ff authored by Damien Le Moal's avatar Damien Le Moal
Browse files

ata: libata-scsi: Cleanup ata_scsi_offline_dev() 



Change the function ata_scsi_offline_dev() to return a bool and change
this function kdoc comment to have the correct mention of its call site.
No functional changes.

Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
parent a0f26fcc

drivers/ata/libata-scsi.c

+7 −8
Original line number Diff line number Diff line
@@ -4633,24 +4633,23 @@ void ata_scsi_scan_host(struct ata_port *ap, int sync) 
 *	ata_scsi_offline_dev - offline attached SCSI device

 *	@dev: ATA device to offline attached SCSI device for

 *

 *	This function is called from ata_eh_hotplug() and responsible

 *	for taking the SCSI device attached to @dev offline.  This

 *	function is called with host lock which protects dev->sdev

 *	against clearing.

 *	This function is called from ata_eh_detach_dev() and is responsible for

 *	taking the SCSI device attached to @dev offline.  This function is

 *	called with host lock which protects dev->sdev against clearing.

 *

 *	LOCKING:

 *	spin_lock_irqsave(host lock)

 *

 *	RETURNS:

 *	1 if attached SCSI device exists, 0 otherwise.

 *	true if attached SCSI device exists, false otherwise.

 */

int ata_scsi_offline_dev(struct ata_device *dev)

bool ata_scsi_offline_dev(struct ata_device *dev)

{

	if (dev->sdev) {

		scsi_device_set_state(dev->sdev, SDEV_OFFLINE);

		return 1;

		return true;

	}

	return 0;

	return false;

}



/**

drivers/ata/libata.h

+1 −1
Original line number Diff line number Diff line
@@ -144,7 +144,7 @@ extern struct ata_device *ata_scsi_find_dev(struct ata_port *ap, 
extern int ata_scsi_add_hosts(struct ata_host *host,

			      const struct scsi_host_template *sht);

extern void ata_scsi_scan_host(struct ata_port *ap, int sync);

extern int ata_scsi_offline_dev(struct ata_device *dev);

extern bool ata_scsi_offline_dev(struct ata_device *dev);

extern bool ata_scsi_sense_is_valid(u8 sk, u8 asc, u8 ascq);

extern void ata_scsi_set_sense(struct ata_device *dev,

			       struct scsi_cmnd *cmd, u8 sk, u8 asc, u8 ascq);