Commit cb589770 authored by He Lugang's avatar He Lugang Committed by Lucas De Marchi
Browse files

drm/xe: use devm_add_action_or_reset() helper 



Use devm_add_action_or_reset() to release resources in case of failure,
because the cleanup function will be automatically called.

Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarHe Lugang <helugang@uniontech.com>
Link: https://patchwork.freedesktop.org/patch/msgid/9631BC17D1E028A2+20240911102215.84865-1-helugang@uniontech.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
(cherry picked from commit fdc81c43)
Signed-off-by: default avatarLucas De Marchi <lucas.demarchi@intel.com>
parent 2d2be279

drivers/gpu/drm/xe/xe_gt_freq.c

+2 −2
Original line number Diff line number Diff line
@@ -237,11 +237,11 @@ int xe_gt_freq_init(struct xe_gt *gt) 
	if (!gt->freq)

		return -ENOMEM;



	err = devm_add_action(xe->drm.dev, freq_fini, gt->freq);

	err = sysfs_create_files(gt->freq, freq_attrs);

	if (err)

		return err;



	err = sysfs_create_files(gt->freq, freq_attrs);

	err = devm_add_action_or_reset(xe->drm.dev, freq_fini, gt->freq);

	if (err)

		return err;

drivers/gpu/drm/xe/xe_gt_sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -51,5 +51,5 @@ int xe_gt_sysfs_init(struct xe_gt *gt) 


	gt->sysfs = &kg->base;



	return devm_add_action(xe->drm.dev, gt_sysfs_fini, gt);

	return devm_add_action_or_reset(xe->drm.dev, gt_sysfs_fini, gt);

}