Commit cb80ecf7 authored by Olga Kornievskaia's avatar Olga Kornievskaia Committed by Chuck Lever
Browse files

NFSD: add cb opcode to WARN_ONCE on failed callback 



It helps to know what kind of callback happened that triggered the
WARN_ONCE in nfsd4_cb_done() function in diagnosing what can set
an uncommon state where both cb_status and tk_status are set at
the same time.

Signed-off-by: default avatarOlga Kornievskaia <okorniev@redhat.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent 1b3e26a5

fs/nfsd/nfs4callback.c

+3 −2
Original line number Diff line number Diff line
@@ -1396,8 +1396,9 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata) 
		return;



	if (cb->cb_status) {

		WARN_ONCE(task->tk_status, "cb_status=%d tk_status=%d",

			  cb->cb_status, task->tk_status);

		WARN_ONCE(task->tk_status,

			  "cb_status=%d tk_status=%d cb_opcode=%d",

			  cb->cb_status, task->tk_status, cb->cb_ops->opcode);

		task->tk_status = cb->cb_status;

	}