Commit cb863540 authored by Luca Ceresoli's avatar Luca Ceresoli
Browse files

drm/bridge: tc358767: fix uninitialized variable regression 



Commit a59a2717 ("drm/bridge: tc358767: convert to
devm_drm_bridge_alloc() API") split tc_probe_bridge_endpoint() in two
functions, thus duplicating the loop over the endpoints in each of those
functions. However it missed duplicating the of_graph_parse_endpoint() call
which initializes the struct of_endpoint, resulting in an uninitialized
read.

Fixes: a59a2717 ("drm/bridge: tc358767: convert to devm_drm_bridge_alloc() API")
Cc: stable@vger.kernel.org
Reported-by: default avatarColin King (gmail) <colin.i.king@gmail.com>
Closes: https://lore.kernel.org/all/056b34c3-c1ea-4b8c-9672-c98903ffd012@gmail.com/


Reviewed-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250704-drm-bridge-alloc-fix-tc358767-regression-v2-1-ec0e511bedd0@bootlin.com


Signed-off-by: default avatarLuca Ceresoli <luca.ceresoli@bootlin.com>
parent 48f05c3b

drivers/gpu/drm/bridge/tc358767.c

+1 −0
Original line number Diff line number Diff line
@@ -2422,6 +2422,7 @@ static int tc_probe_bridge_endpoint(struct tc_data *tc, enum tc_mode mode) 
	struct device_node *node = NULL;



	for_each_endpoint_of_node(dev->of_node, node) {

		of_graph_parse_endpoint(node, &endpoint);

		if (endpoint.port == 2) {

			of_property_read_u8_array(node, "toshiba,pre-emphasis",

						  tc->pre_emphasis,