Commit cbfa5be2 authored by Justin Chen's avatar Justin Chen Committed by Jakub Kicinski
Browse files

net: bcmasp: fix double free of WoL irq 



We do not need to free wol_irq since it was instantiated with
devm_request_irq(). So devres will free for us.

Fixes: a2f07512 ("net: bcmasp: Add support for WoL magic packet")
Signed-off-by: default avatarJustin Chen <justin.chen@broadcom.com>
Reviewed-by: default avatarFlorian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20260319234813.1937315-2-justin.chen@broadcom.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7a4fc5ca

drivers/net/ethernet/broadcom/asp2/bcmasp.c

+0 −8
Original line number Diff line number Diff line
@@ -1152,12 +1152,6 @@ void bcmasp_enable_wol(struct bcmasp_intf *intf, bool en) 
	}

}



static void bcmasp_wol_irq_destroy(struct bcmasp_priv *priv)

{

	if (priv->wol_irq > 0)

		free_irq(priv->wol_irq, priv);

}



static void bcmasp_eee_fixup(struct bcmasp_intf *intf, bool en)

{

	u32 reg, phy_lpi_overwrite;
@@ -1363,7 +1357,6 @@ static int bcmasp_probe(struct platform_device *pdev) 
	return ret;



err_cleanup:

	bcmasp_wol_irq_destroy(priv);

	bcmasp_remove_intfs(priv);



	return ret;
@@ -1376,7 +1369,6 @@ static void bcmasp_remove(struct platform_device *pdev) 
	if (!priv)

		return;



	bcmasp_wol_irq_destroy(priv);

	bcmasp_remove_intfs(priv);

}