Commit cc5cfc11 authored by Bharat Bhushan's avatar Bharat Bhushan Committed by Wim Van Sebroeck
Browse files

drivers: watchdog: marvell_gti: fix zero pretimeout handling 



When pretimeout is set to 0 then do not reprogram timer
with zero timeout, this will reset device immediately.
Also disable interrupt to stop pretimeout notification.

Signed-off-by: default avatarBharat Bhushan <bbhushan2@marvell.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231009044037.514570-1-bbhushan2@marvell.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@linux-watchdog.org>
parent cd09da47

drivers/watchdog/marvell_gti_wdt.c

+7 −0
Original line number Diff line number Diff line
@@ -190,6 +190,13 @@ static int gti_wdt_set_pretimeout(struct watchdog_device *wdev, 
	struct gti_wdt_priv *priv = watchdog_get_drvdata(wdev);

	struct watchdog_device *wdog_dev = &priv->wdev;



	if (!timeout) {

		/* Disable Interrupt */

		writeq(GTI_CWD_INT_ENA_CLR_VAL(priv->wdt_timer_idx),

		       priv->base + GTI_CWD_INT_ENA_CLR);

		return 0;

	}



	/* pretimeout should 1/3 of max_timeout */

	if (timeout * 3 <= wdog_dev->max_timeout)

		return gti_wdt_settimeout(wdev, timeout * 3);