Commit cc7c9cbe authored by Jiri Slaby (SUSE)'s avatar Jiri Slaby (SUSE) Committed by Greg Kroah-Hartman
Browse files

serial: 8250: extract serial8250_set_trigger_for_slow_speed() 



serial8250_do_set_termios() consists of many registers and up flags
settings. Extract all these into separate functions. This time, setting
of trigger level for slow speeds.

Signed-off-by: default avatar"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20250611100319.186924-20-jirislaby@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 0fa5aa0b

drivers/tty/serial/8250/8250_port.c

+19 −7
Original line number Diff line number Diff line
@@ -2686,6 +2686,24 @@ static void serial8250_set_mini(struct uart_port *port, struct ktermios *termios 
	}

}



static void serial8250_set_trigger_for_slow_speed(struct uart_port *port, struct ktermios *termios,

						  unsigned int baud)

{

	struct uart_8250_port *up = up_to_u8250p(port);



	if (!(up->capabilities & UART_CAP_FIFO))

		return;

	if (port->fifosize <= 1)

		return;

	if (baud >= 2400)

		return;

	if (up->dma)

		return;



	up->fcr &= ~UART_FCR_TRIGGER_MASK;

	up->fcr |= UART_FCR_TRIGGER_1;

}



void

serial8250_do_set_termios(struct uart_port *port, struct ktermios *termios,

		          const struct ktermios *old)
@@ -2710,13 +2728,7 @@ serial8250_do_set_termios(struct uart_port *port, struct ktermios *termios, 
	uart_port_lock_irqsave(port, &flags);



	up->lcr = cval;					/* Save computed LCR */



	if (up->capabilities & UART_CAP_FIFO && port->fifosize > 1) {

		if (baud < 2400 && !up->dma) {

			up->fcr &= ~UART_FCR_TRIGGER_MASK;

			up->fcr |= UART_FCR_TRIGGER_1;

		}

	}

	serial8250_set_trigger_for_slow_speed(port, termios, baud);



	/*

	 * MCR-based auto flow control.  When AFE is enabled, RTS will be