Commit cc85cb96 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Linus Walleij
Browse files

pinctrl: qcom: make the pinmuxing strict 



The strict flag in struct pinmux_ops disallows the usage of the same pin
as a GPIO and for another function. Without it, a rouge user-space
process with enough privileges (or even a buggy driver) can request a
used pin as GPIO and drive it, potentially confusing devices or even
crashing the system. Set it globally for all pinctrl-msm users.

Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tested-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 480dc195

drivers/pinctrl/qcom/pinctrl-msm.c

+1 −0
Original line number Diff line number Diff line
@@ -268,6 +268,7 @@ static const struct pinmux_ops msm_pinmux_ops = { 
	.function_is_gpio	= pinmux_generic_function_is_gpio,

	.gpio_request_enable	= msm_pinmux_request_gpio,

	.set_mux		= msm_pinmux_set_mux,

	.strict			= true,

};



static int msm_config_reg(struct msm_pinctrl *pctrl,