Commit cc87b7c0 authored Dec 03, 2023 by Masahiro Yamada

modpost: move attribute((format(printf, 2, 3))) to modpost.h



This attribute must be added to the function declaration in a header
for comprehensive checking of all the callsites.

Fixes: 6d9a89ea ("kbuild: declare the modpost error functions as printf like")
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>

parent cbe826b0

scripts/mod/modpost.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -60,8 +60,7 @@ static unsigned int nr_unresolved;

		#define MODULE_NAME_LEN (64 - sizeof(Elf_Addr))

		void __attribute__((format(printf, 2, 3)))
		modpost_log(enum loglevel loglevel, const char *fmt, ...)
		void modpost_log(enum loglevel loglevel, const char *fmt, ...)
		{
		va_list arglist;

scripts/mod/modpost.h

+2 −1

Original line number	Diff line number	Diff line
		@@ -197,7 +197,8 @@ enum loglevel {
		LOG_FATAL
		};

		void modpost_log(enum loglevel loglevel, const char *fmt, ...);
		void __attribute__((format(printf, 2, 3)))
		modpost_log(enum loglevel loglevel, const char *fmt, ...);

		/*
		* warn - show the given message, then let modpost continue running, still