Unverified Commit cc8b2211 authored by Raag Jadav's avatar Raag Jadav Committed by Rodrigo Vivi
Browse files

drm/xe/i2c: Introduce xe_i2c_present() 



In preparation of wider usecases which require checking for I2C
controller presence, introduce xe_i2c_present() helper.

v2: Doc fix (Riana)

Suggested-by: default avatarRiana Tauro <riana.tauro@intel.com>
Signed-off-by: default avatarRaag Jadav <raag.jadav@intel.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: default avatarRiana Tauro <riana.tauro@intel.com>
Link: https://lore.kernel.org/r/20250814091845.1356135-1-raag.jadav@intel.com


Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 32a4d1b9

drivers/gpu/drm/xe/xe_i2c.c

+16 −2
Original line number Diff line number Diff line
@@ -146,6 +146,20 @@ static void xe_i2c_unregister_adapter(struct xe_i2c *i2c) 
	fwnode_remove_software_node(i2c->adapter_node);

}



/**

 * xe_i2c_present - I2C controller is present and functional

 * @xe: xe device instance

 *

 * Check whether the I2C controller is present and functioning with valid

 * endpoint cookie.

 *

 * Return: %true if present, %false otherwise.

 */

bool xe_i2c_present(struct xe_device *xe)

{

	return xe->i2c && xe->i2c->ep.cookie == XE_I2C_EP_COOKIE_DEVICE;

}



/**

 * xe_i2c_irq_handler: Handler for I2C interrupts

 * @xe: xe device instance
@@ -230,7 +244,7 @@ void xe_i2c_pm_suspend(struct xe_device *xe) 
{

	struct xe_mmio *mmio = xe_root_tile_mmio(xe);



	if (!xe->i2c || xe->i2c->ep.cookie != XE_I2C_EP_COOKIE_DEVICE)

	if (!xe_i2c_present(xe))

		return;



	xe_mmio_rmw32(mmio, I2C_CONFIG_PMCSR, PCI_PM_CTRL_STATE_MASK, (__force u32)PCI_D3hot);
@@ -241,7 +255,7 @@ void xe_i2c_pm_resume(struct xe_device *xe, bool d3cold) 
{

	struct xe_mmio *mmio = xe_root_tile_mmio(xe);



	if (!xe->i2c || xe->i2c->ep.cookie != XE_I2C_EP_COOKIE_DEVICE)

	if (!xe_i2c_present(xe))

		return;



	if (d3cold)

drivers/gpu/drm/xe/xe_i2c.h

+2 −0
Original line number Diff line number Diff line
@@ -49,11 +49,13 @@ struct xe_i2c { 


#if IS_ENABLED(CONFIG_I2C)

int xe_i2c_probe(struct xe_device *xe);

bool xe_i2c_present(struct xe_device *xe);

void xe_i2c_irq_handler(struct xe_device *xe, u32 master_ctl);

void xe_i2c_pm_suspend(struct xe_device *xe);

void xe_i2c_pm_resume(struct xe_device *xe, bool d3cold);

#else

static inline int xe_i2c_probe(struct xe_device *xe) { return 0; }

static inline bool xe_i2c_present(struct xe_device *xe) { return false; }

static inline void xe_i2c_irq_handler(struct xe_device *xe, u32 master_ctl) { }

static inline void xe_i2c_pm_suspend(struct xe_device *xe) { }

static inline void xe_i2c_pm_resume(struct xe_device *xe, bool d3cold) { }