Commit cc8d9cbf authored by Pagadala Yesu Anjaneyulu's avatar Pagadala Yesu Anjaneyulu Committed by Miri Korenblit
Browse files

wifi: iwlwifi: fw: Fix possible memory leak in iwl_fw_dbg_collect 



Ensure descriptor is freed on error to avoid memory leak.

Signed-off-by: default avatarPagadala Yesu Anjaneyulu <pagadala.yesu.anjaneyulu@intel.com>
Signed-off-by: default avatarMiri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20250611222325.8158d15ec866.Ifa3e422c302397111f20a16da7509e6574bc19e3@changeid
parent 8dab046d

drivers/net/wireless/intel/iwlwifi/fw/dbg.c

+6 −1
Original line number Diff line number Diff line
@@ -3008,6 +3008,7 @@ int iwl_fw_dbg_collect(struct iwl_fw_runtime *fwrt, 
	struct iwl_fw_dump_desc *desc;

	unsigned int delay = 0;

	bool monitor_only = false;

	int ret;



	if (trigger) {

		u16 occurrences = le16_to_cpu(trigger->occurrences) - 1;
@@ -3038,7 +3039,11 @@ int iwl_fw_dbg_collect(struct iwl_fw_runtime *fwrt, 
	desc->trig_desc.type = cpu_to_le32(trig);

	memcpy(desc->trig_desc.data, str, len);



	return iwl_fw_dbg_collect_desc(fwrt, desc, monitor_only, delay);

	ret = iwl_fw_dbg_collect_desc(fwrt, desc, monitor_only, delay);

	if (ret)

		kfree(desc);



	return ret;

}

IWL_EXPORT_SYMBOL(iwl_fw_dbg_collect);