Commit cc937dad authored by Edward Liaw's avatar Edward Liaw Committed by Andrew Morton
Browse files

selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk 

Centralize the _GNU_SOURCE definition to CFLAGS in lib.mk.  Remove
redundant defines from Makefiles that import lib.mk.  Convert any usage of
"#define _GNU_SOURCE 1" to "#define _GNU_SOURCE".

This uses the form "-D_GNU_SOURCE=", which is equivalent to
"#define _GNU_SOURCE".

Otherwise using "-D_GNU_SOURCE" is equivalent to "-D_GNU_SOURCE=1" and
"#define _GNU_SOURCE 1", which is less commonly seen in source code and
would require many changes in selftests to avoid redefinition warnings.

Link: https://lkml.kernel.org/r/20240625223454.1586259-2-edliaw@google.com


Signed-off-by: default avatarEdward Liaw <edliaw@google.com>
Suggested-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
Acked-by: default avatarShuah Khan <skhan@linuxfoundation.org>
Reviewed-by: default avatarMuhammad Usama Anjum <usama.anjum@collabora.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: André Almeida <andrealmeid@igalia.com>
Cc: Darren Hart <dvhart@infradead.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: David S. Miller <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Kees Cook <kees@kernel.org>
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Reinette Chatre <reinette.chatre@intel.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 95139d94

tools/testing/selftests/exec/Makefile

+0 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0

CFLAGS = -Wall

CFLAGS += -Wno-nonnull

CFLAGS += -D_GNU_SOURCE



TEST_PROGS := binfmt_script.py

TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 non-regular

tools/testing/selftests/futex/functional/Makefile

+1 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0

INCLUDES := -I../include -I../../ $(KHDR_INCLUDES)

CFLAGS := $(CFLAGS) -g -O2 -Wall -D_GNU_SOURCE= -pthread $(INCLUDES) $(KHDR_INCLUDES)

CFLAGS := $(CFLAGS) -g -O2 -Wall -pthread $(INCLUDES) $(KHDR_INCLUDES)

LDLIBS := -lpthread -lrt



LOCAL_HDRS := \

tools/testing/selftests/intel_pstate/Makefile

+1 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0

CFLAGS := $(CFLAGS) -Wall -D_GNU_SOURCE

CFLAGS := $(CFLAGS) -Wall

LDLIBS += -lm



ARCH ?= $(shell uname -m 2>/dev/null || echo not)

tools/testing/selftests/iommu/Makefile

+0 −2
Original line number Diff line number Diff line
@@ -2,8 +2,6 @@ 
CFLAGS += -Wall -O2 -Wno-unused-function

CFLAGS += $(KHDR_INCLUDES)



CFLAGS += -D_GNU_SOURCE



TEST_GEN_PROGS :=

TEST_GEN_PROGS += iommufd

TEST_GEN_PROGS += iommufd_fail_nth

tools/testing/selftests/kvm/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -231,7 +231,7 @@ LINUX_TOOL_ARCH_INCLUDE = $(top_srcdir)/tools/arch/$(ARCH)/include 
endif

CFLAGS += -Wall -Wstrict-prototypes -Wuninitialized -O2 -g -std=gnu99 \

	-Wno-gnu-variable-sized-type-not-at-end -MD -MP -DCONFIG_64BIT \

	-D_GNU_SOURCE -fno-builtin-memcmp -fno-builtin-memcpy \

	-fno-builtin-memcmp -fno-builtin-memcpy \

	-fno-builtin-memset -fno-builtin-strnlen \

	-fno-stack-protector -fno-PIE -I$(LINUX_TOOL_INCLUDE) \

	-I$(LINUX_TOOL_ARCH_INCLUDE) -I$(LINUX_HDR_PATH) -Iinclude \