Commit ccb22ca2 authored Oct 15, 2024 by Alice Ryhl Committed by Greg Kroah-Hartman Oct 15, 2024

rust: miscdevice: fix warning on c_uint to u32 cast

When building miscdevice with clippy warnings, the following warning is
emitted:

	warning: casting to the same type is unnecessary (`u32` -> `u32`)
	   --> /home/aliceryhl/rust-for-linux/rust/kernel/miscdevice.rs:220:28
	    |
	220 |     match T::ioctl(device, cmd as u32, arg as usize) {
	    |                            ^^^^^^^^^^ help: try: `cmd`
	    |
	    = help: for further information visit
	      https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast


	    = note: `-W clippy::unnecessary-cast` implied by `-W clippy::all`
	    = help: to override `-W clippy::all` add `#[allow(clippy::unnecessary_cast)]`

Thus, fix it.

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Link: https://lore.kernel.org/r/20241015-miscdevice-cint-cast-v1-1-fcf4b75700ac@google.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 619325ca

rust/kernel/miscdevice.rs

+2 −2

Original line number	Diff line number	Diff line
		@@ -217,7 +217,7 @@ impl<T: MiscDevice> VtableHelper<T> {
		// SAFETY: Ioctl calls can borrow the private data of the file.
		let device = unsafe { <T::Ptr as ForeignOwnable>::borrow(private) };

		match T::ioctl(device, cmd as u32, arg as usize) {
		match T::ioctl(device, cmd, arg as usize) {
		Ok(ret) => ret as c_long,
		Err(err) => err.to_errno() as c_long,
		}
		@@ -234,7 +234,7 @@ impl<T: MiscDevice> VtableHelper<T> {
		// SAFETY: Ioctl calls can borrow the private data of the file.
		let device = unsafe { <T::Ptr as ForeignOwnable>::borrow(private) };

		match T::compat_ioctl(device, cmd as u32, arg as usize) {
		match T::compat_ioctl(device, cmd, arg as usize) {
		Ok(ret) => ret as c_long,
		Err(err) => err.to_errno() as c_long,
		}