Commit ccbfcac0 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: timer: Relax start tick time check for slave timer elements 

The recent addition of a sanity check for a too low start tick time
seems breaking some applications that uses aloop with a certain slave
timer setup.  They may have the initial resolution 0, hence it's
treated as if it were a too low value.

Relax and skip the check for the slave timer instance for addressing
the regression.

Fixes: 4a63bd17 ("ALSA: timer: Set lower bound of start tick time")
Cc: <stable@vger.kernel.org>
Link: https://github.com/raspberrypi/linux/issues/6294
Link: https://patch.msgid.link/20240810084833.10939-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent d3e82ced

sound/core/timer.c

+1 −1
Original line number Diff line number Diff line
@@ -547,7 +547,7 @@ static int snd_timer_start1(struct snd_timer_instance *timeri, 
	/* check the actual time for the start tick;

	 * bail out as error if it's way too low (< 100us)

	 */

	if (start) {

	if (start && !(timer->hw.flags & SNDRV_TIMER_HW_SLAVE)) {

		if ((u64)snd_timer_hw_resolution(timer) * ticks < 100000)

			return -EINVAL;

	}